diff mbox series

[v7,05/11] dt-bindings: connector: Add property to set initial current cap for FRS

Message ID 20200917101856.3156869-5-badhri@google.com
State New
Headers show
Series [v7,01/11] usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference | expand

Commit Message

Badhri Jagan Sridharan Sept. 17, 2020, 10:18 a.m. UTC
This change adds frs-typec-current which allows setting the initial current
capability of the new source when vSafe5V is applied during PD3.0
sink Fast Role Swap.

Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
---
Changes since v1:
- Changing patch version to v6 to fix version number confusion.

Changes since v6:
- Removed the redundant usb-connector.txt that I created by mistake.
- Moved to yaml.
---
 .../devicetree/bindings/connector/usb-connector.yaml   |  8 ++++++++
 include/dt-bindings/usb/pd.h                           | 10 ++++++++++
 2 files changed, 18 insertions(+)

Comments

Greg KH Sept. 20, 2020, 2:09 p.m. UTC | #1
On Thu, Sep 17, 2020 at 03:18:50AM -0700, Badhri Jagan Sridharan wrote:
> This change adds frs-typec-current which allows setting the initial current
> capability of the new source when vSafe5V is applied during PD3.0
> sink Fast Role Swap.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> Changes since v1:
> - Changing patch version to v6 to fix version number confusion.
> 
> Changes since v6:
> - Removed the redundant usb-connector.txt that I created by mistake.
> - Moved to yaml.
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml   |  8 ++++++++
>  include/dt-bindings/usb/pd.h                           | 10 ++++++++++
>  2 files changed, 18 insertions(+)

Don't you need to cc: the DT maintainers for new DT bindings?

thanks,

greg k-h
Badhri Jagan Sridharan Sept. 20, 2020, 11:06 p.m. UTC | #2
Hi Greg,

Yes. Have CC'ed all the DT maintainers for v8. Was waiting to see if
it was OK code wise.
Heikki had given his reviewed-by tag on v7.

Thanks,
Badhri

On Sun, Sep 20, 2020 at 7:09 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>

> On Thu, Sep 17, 2020 at 03:18:50AM -0700, Badhri Jagan Sridharan wrote:

> > This change adds frs-typec-current which allows setting the initial current

> > capability of the new source when vSafe5V is applied during PD3.0

> > sink Fast Role Swap.

> >

> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>

> > ---

> > Changes since v1:

> > - Changing patch version to v6 to fix version number confusion.

> >

> > Changes since v6:

> > - Removed the redundant usb-connector.txt that I created by mistake.

> > - Moved to yaml.

> > ---

> >  .../devicetree/bindings/connector/usb-connector.yaml   |  8 ++++++++

> >  include/dt-bindings/usb/pd.h                           | 10 ++++++++++

> >  2 files changed, 18 insertions(+)

>

> Don't you need to cc: the DT maintainers for new DT bindings?

>

> thanks,

>

> greg k-h
Greg KH Sept. 22, 2020, 8:40 a.m. UTC | #3
On Sun, Sep 20, 2020 at 04:06:05PM -0700, Badhri Jagan Sridharan wrote:
> Hi Greg,
> 
> Yes. Have CC'ed all the DT maintainers for v8. Was waiting to see if
> it was OK code wise.
> Heikki had given his reviewed-by tag on v7.

But this is v7 (so says the subject line...)

Totally confused,

greg k-h
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index 9bd52e63c935..1ca8e6a337e5 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -142,6 +142,14 @@  properties:
     required:
       - port@0
 
+  frs-typec-current:
+    description: Initial current capability of the new source when vSafe5V
+      is applied during PD3.0 Fast Role Swap. "Table 6-14 Fixed Supply PDO - Sink"
+      of "USB Power Delivery Specification Revision 3.0, Version 1.2" provides the
+      different power levels and "6.4.1.3.1.6 Fast Role Swap USB Type-C Current"
+      provides a detailed description of the field.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
 required:
   - compatible
 
diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
index 985f2bbd4d24..db1ad4532197 100644
--- a/include/dt-bindings/usb/pd.h
+++ b/include/dt-bindings/usb/pd.h
@@ -35,6 +35,16 @@ 
 
 #define VSAFE5V 5000 /* mv units */
 
+/*
+ * Based on "Table 6-14 Fixed Supply PDO - Sink" of "USB Power Delivery Specification Revision 3.0,
+ * Version 1.2"
+ * Initial current capability of the new source when vSafe5V is applied.
+ */
+#define FRS_NOT_SUPPORTED	0
+#define FRS_DEFAULT_POWER	1
+#define FRS_5V_1P5A		2
+#define FRS_5V_3A		3
+
 #define PDO_BATT_MAX_VOLT_SHIFT	20	/* 50mV units */
 #define PDO_BATT_MIN_VOLT_SHIFT	10	/* 50mV units */
 #define PDO_BATT_MAX_PWR_SHIFT	0	/* 250mW units */