diff mbox series

[01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call

Message ID 20201203124803.23390-1-info@metux.net
State New
Headers show
Series [01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call | expand

Commit Message

Enrico Weigelt, metux IT consult Dec. 3, 2020, 12:47 p.m. UTC
Remove MODULE_VERSION(), as it doesn't seem to serve any practical
purpose. For in-tree drivers, the kernel version matters.

The drivers have received lots of changes, without the module version
(or the underlying DRV_VERSION macro) ever changed, since the code
landed in the kernel tree. So, it doesn't seem to have any practical
meaning anymore.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/accessibility/speakup/main.c           | 1 -
 drivers/accessibility/speakup/speakup_acntpc.c | 1 -
 drivers/accessibility/speakup/speakup_acntsa.c | 1 -
 drivers/accessibility/speakup/speakup_apollo.c | 2 --
 drivers/accessibility/speakup/speakup_audptr.c | 2 --
 drivers/accessibility/speakup/speakup_bns.c    | 2 --
 drivers/accessibility/speakup/speakup_decext.c | 1 -
 drivers/accessibility/speakup/speakup_decpc.c  | 1 -
 drivers/accessibility/speakup/speakup_dectlk.c | 1 -
 drivers/accessibility/speakup/speakup_dtlk.c   | 2 --
 drivers/accessibility/speakup/speakup_dummy.c  | 2 --
 drivers/accessibility/speakup/speakup_keypc.c  | 1 -
 drivers/accessibility/speakup/speakup_ltlk.c   | 2 --
 drivers/accessibility/speakup/speakup_soft.c   | 1 -
 drivers/accessibility/speakup/speakup_spkout.c | 2 --
 drivers/accessibility/speakup/speakup_txprt.c  | 2 --
 16 files changed, 24 deletions(-)

Comments

Greg KH Dec. 3, 2020, 1:25 p.m. UTC | #1
On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> purpose. For in-tree drivers, the kernel version matters.
> 
> The drivers have received lots of changes, without the module version
> (or the underlying DRV_VERSION macro) ever changed, since the code
> landed in the kernel tree. So, it doesn't seem to have any practical
> meaning anymore.
> 
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  drivers/accessibility/speakup/main.c           | 1 -

<snip>

Yous subject line is odd, these are not "staging" drivers anymore, so
why do you say they are there?

thanks,

greg k-h
Dan Carpenter Dec. 3, 2020, 1:56 p.m. UTC | #2
On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote:
> On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> > purpose. For in-tree drivers, the kernel version matters.
> > 
> > The drivers have received lots of changes, without the module version
> > (or the underlying DRV_VERSION macro) ever changed, since the code
> > landed in the kernel tree. So, it doesn't seem to have any practical
> > meaning anymore.
> > 
> > Signed-off-by: Enrico Weigelt <info@metux.net>
> > ---
> >  drivers/accessibility/speakup/main.c           | 1 -
> 
> <snip>
> 
> Yous subject line is odd, these are not "staging" drivers anymore, so
> why do you say they are there?

Also putting "drivers:" in the subject always seems superfluous.

regards,
dan carpenter
Greg KH Dec. 4, 2020, 3:47 p.m. UTC | #3
On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
> For in-kernel drivers, the kernel version matters. The driver received lots
> of changes, but version number has remained the same since it's introducing
> into mainline, seven years ago. So, it doesn't seem to have much practical
> meaning anymore.
> 
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  drivers/staging/goldfish/goldfish_audio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index 0c65a0121dde..4a23f40e549a 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -24,7 +24,6 @@
>  MODULE_AUTHOR("Google, Inc.");
>  MODULE_DESCRIPTION("Android QEMU Audio Driver");
>  MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
>  
>  struct goldfish_audio {
>  	char __iomem *reg_base;

This file isn't even in my tree, are you sure you made this patch series
against the correct branch/tree?

Please fix this series up and resend.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
index 48019660a096..d512f4775ae1 100644
--- a/drivers/accessibility/speakup/main.c
+++ b/drivers/accessibility/speakup/main.c
@@ -46,7 +46,6 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("Daniel Drake <dsd@gentoo.org>");
 MODULE_DESCRIPTION("Speakup console speech");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(SPEAKUP_VERSION);
 
 char *synth_name;
 module_param_named(synth, synth_name, charp, 0444);
diff --git a/drivers/accessibility/speakup/speakup_acntpc.c b/drivers/accessibility/speakup/speakup_acntpc.c
index c94328a5bd4a..4d9ebf8b3460 100644
--- a/drivers/accessibility/speakup/speakup_acntpc.c
+++ b/drivers/accessibility/speakup/speakup_acntpc.c
@@ -315,5 +315,4 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Accent PC synthesizer");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
 
diff --git a/drivers/accessibility/speakup/speakup_acntsa.c b/drivers/accessibility/speakup/speakup_acntsa.c
index 3a863dc61286..1dc2fd99043f 100644
--- a/drivers/accessibility/speakup/speakup_acntsa.c
+++ b/drivers/accessibility/speakup/speakup_acntsa.c
@@ -140,5 +140,4 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Accent SA synthesizer");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
 
diff --git a/drivers/accessibility/speakup/speakup_apollo.c b/drivers/accessibility/speakup/speakup_apollo.c
index 0877b4044c28..ce215fb3f7ff 100644
--- a/drivers/accessibility/speakup/speakup_apollo.c
+++ b/drivers/accessibility/speakup/speakup_apollo.c
@@ -204,5 +204,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Apollo II synthesizer");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_audptr.c b/drivers/accessibility/speakup/speakup_audptr.c
index e6a6a9665d8f..e4733215b5a9 100644
--- a/drivers/accessibility/speakup/speakup_audptr.c
+++ b/drivers/accessibility/speakup/speakup_audptr.c
@@ -167,5 +167,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Audapter synthesizer");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_bns.c b/drivers/accessibility/speakup/speakup_bns.c
index 76dfa3f7c058..6783b007c020 100644
--- a/drivers/accessibility/speakup/speakup_bns.c
+++ b/drivers/accessibility/speakup/speakup_bns.c
@@ -124,5 +124,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Braille 'n Speak synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_decext.c b/drivers/accessibility/speakup/speakup_decext.c
index 7408eb29cf38..efe7ccbfbf05 100644
--- a/drivers/accessibility/speakup/speakup_decext.c
+++ b/drivers/accessibility/speakup/speakup_decext.c
@@ -236,5 +236,4 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for DECtalk External synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
 
diff --git a/drivers/accessibility/speakup/speakup_decpc.c b/drivers/accessibility/speakup/speakup_decpc.c
index 96f24c848cc5..60da9ec9949c 100644
--- a/drivers/accessibility/speakup/speakup_decpc.c
+++ b/drivers/accessibility/speakup/speakup_decpc.c
@@ -492,4 +492,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for DECtalk PC synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c
index 780214b5ca16..dc5e91c7a2c9 100644
--- a/drivers/accessibility/speakup/speakup_dectlk.c
+++ b/drivers/accessibility/speakup/speakup_dectlk.c
@@ -307,5 +307,4 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for DECtalk Express synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
 
diff --git a/drivers/accessibility/speakup/speakup_dtlk.c b/drivers/accessibility/speakup/speakup_dtlk.c
index dbebed0eeeec..265ab003627e 100644
--- a/drivers/accessibility/speakup/speakup_dtlk.c
+++ b/drivers/accessibility/speakup/speakup_dtlk.c
@@ -386,5 +386,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for DoubleTalk PC synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_dummy.c b/drivers/accessibility/speakup/speakup_dummy.c
index e393438af81b..f3b38dc04499 100644
--- a/drivers/accessibility/speakup/speakup_dummy.c
+++ b/drivers/accessibility/speakup/speakup_dummy.c
@@ -130,5 +130,3 @@  module_spk_synth(synth_dummy);
 MODULE_AUTHOR("Samuel Thibault <samuel.thibault@ens-lyon.org>");
 MODULE_DESCRIPTION("Speakup support for text console");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c
index 414827e888fc..8110ddea8ef3 100644
--- a/drivers/accessibility/speakup/speakup_keypc.c
+++ b/drivers/accessibility/speakup/speakup_keypc.c
@@ -314,5 +314,4 @@  module_spk_synth(synth_keypc);
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Keynote Gold PC synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
 
diff --git a/drivers/accessibility/speakup/speakup_ltlk.c b/drivers/accessibility/speakup/speakup_ltlk.c
index 3c59519a871f..d506380d7235 100644
--- a/drivers/accessibility/speakup/speakup_ltlk.c
+++ b/drivers/accessibility/speakup/speakup_ltlk.c
@@ -171,5 +171,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for DoubleTalk LT/LiteTalk synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
index 9a7029539f35..7c97444744ea 100644
--- a/drivers/accessibility/speakup/speakup_soft.c
+++ b/drivers/accessibility/speakup/speakup_soft.c
@@ -427,4 +427,3 @@  module_spk_synth(synth_soft);
 MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_DESCRIPTION("Speakup userspace software synthesizer support");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_spkout.c b/drivers/accessibility/speakup/speakup_spkout.c
index 6e933bf1de2e..dbaec515d94e 100644
--- a/drivers/accessibility/speakup/speakup_spkout.c
+++ b/drivers/accessibility/speakup/speakup_spkout.c
@@ -135,5 +135,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Speak Out synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_txprt.c b/drivers/accessibility/speakup/speakup_txprt.c
index a7326f226a5e..687efe2f02e6 100644
--- a/drivers/accessibility/speakup/speakup_txprt.c
+++ b/drivers/accessibility/speakup/speakup_txprt.c
@@ -123,5 +123,3 @@  MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
 MODULE_AUTHOR("David Borowski");
 MODULE_DESCRIPTION("Speakup support for Transport synthesizers");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-