diff mbox series

[01/12] media: atomsip: Convert comments to C99 initializers

Message ID 20201207192638.15219-2-Philipp.Gerlesberger@fau.de
State New
Headers show
Series [01/12] media: atomsip: Convert comments to C99 initializers | expand

Commit Message

Philipp Gerlesberger Dec. 7, 2020, 7:26 p.m. UTC
The struct initalizers have been changed as recommended on
https://kernelnewbies.org/KernelJanitors/Todo

Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
---
 .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c  | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

Comments

Dan Carpenter Dec. 8, 2020, 10:21 a.m. UTC | #1
On Mon, Dec 07, 2020 at 08:26:27PM +0100, Philipp Gerlesberger wrote:
> The struct initalizers have been changed as recommended on

> https://kernelnewbies.org/KernelJanitors/Todo

> 

> Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>

> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>

> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>

> ---

>  .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c  | 30 +++++++++----------

>  1 file changed, 15 insertions(+), 15 deletions(-)

> 

> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c

> index b4f53be18e7f..af61d05e88d3 100644

> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c

> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c

> @@ -31,33 +31,33 @@ static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];

>   * @brief VBUF resource pool - refpool

>   */

>  static struct ia_css_rmgr_vbuf_pool refpool = {

> -	false,			/* copy_on_write */

> -	false,			/* recycle */

> -	0,			/* size */

> -	0,			/* index */

> -	NULL,			/* handles */

> +	.copy_on_write	= false,

> +	.recycle	= false,

> +	.size		= 0,

> +	.index		= 0,

> +	.handles	= NULL,


If you're using C99 initializers then you can remove all the false, 0
and NULL members.

regards,
dan carpenter
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
index b4f53be18e7f..af61d05e88d3 100644
--- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
+++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
@@ -31,33 +31,33 @@  static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];
  * @brief VBUF resource pool - refpool
  */
 static struct ia_css_rmgr_vbuf_pool refpool = {
-	false,			/* copy_on_write */
-	false,			/* recycle */
-	0,			/* size */
-	0,			/* index */
-	NULL,			/* handles */
+	.copy_on_write	= false,
+	.recycle	= false,
+	.size		= 0,
+	.index		= 0,
+	.handles	= NULL,
 };
 
 /*
  * @brief VBUF resource pool - writepool
  */
 static struct ia_css_rmgr_vbuf_pool writepool = {
-	true,			/* copy_on_write */
-	false,			/* recycle */
-	0,			/* size */
-	0,			/* index */
-	NULL,			/* handles */
+	.copy_on_write	= true,
+	.recycle	= false,
+	.size		= 0,
+	.index		= 0,
+	.handles	= NULL,
 };
 
 /*
  * @brief VBUF resource pool - hmmbufferpool
  */
 static struct ia_css_rmgr_vbuf_pool hmmbufferpool = {
-	true,			/* copy_on_write */
-	true,			/* recycle */
-	32,			/* size */
-	0,			/* index */
-	NULL,			/* handles */
+	.copy_on_write	= true,
+	.recycle	= true,
+	.size		= 32,
+	.index		= 0,
+	.handles	= NULL,
 };
 
 struct ia_css_rmgr_vbuf_pool *vbuf_ref = &refpool;