diff mbox series

[01/15] irqchip: Allow to compile bcmstb on other platforms

Message ID 20201210134648.272857-2-maxime@cerno.tech
State New
Headers show
Series drm/vc4: hdmi: Add CEC support for the BCM2711 | expand

Commit Message

Maxime Ripard Dec. 10, 2020, 1:46 p.m. UTC
The BCM2711 uses a number of instances of the bcmstb-l2 controller in its
display engine. Let's allow the driver to be enabled through KConfig.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli Dec. 10, 2020, 5:33 p.m. UTC | #1
On 12/10/2020 5:46 AM, Maxime Ripard wrote:
> The BCM2711 uses a number of instances of the bcmstb-l2 controller in its
> display engine. Let's allow the driver to be enabled through KConfig.
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Maxime Ripard Dec. 14, 2020, 3:27 p.m. UTC | #2
Hi Marc,

On Thu, Dec 10, 2020 at 05:59:09PM +0000, Marc Zyngier wrote:
> On 2020-12-10 13:46, Maxime Ripard wrote:

> > The BCM2711 uses a number of instances of the bcmstb-l2 controller in

> > its

> > display engine. Let's allow the driver to be enabled through KConfig.

> > 

> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>

> > ---

> >  drivers/irqchip/Kconfig | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > 

> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig

> > index c6098eee0c7c..f1e58de117dc 100644

> > --- a/drivers/irqchip/Kconfig

> > +++ b/drivers/irqchip/Kconfig

> > @@ -131,7 +131,7 @@ config BCM7120_L2_IRQ

> >  	select IRQ_DOMAIN

> > 

> >  config BRCMSTB_L2_IRQ

> > -	bool

> > +	bool "Broadcom STB L2 Interrupt Controller"

> >  	select GENERIC_IRQ_CHIP

> >  	select IRQ_DOMAIN

> 

> I'm always sceptical of making interrupt controllers user-selectable.

> Who is going to know that they need to pick that one?

> 

> I'd be much more in favour of directly selecting this symbol

> from DRM_VC4_HDMI_CEC, since there is an obvious dependency.


It's a bit weird to me that the HDMI CEC support selects it, since that
interrupt controller is external and here no matter what. Would
selecting it from the ARCH_* Kconfig option work for you?

Thanks!
Maxime
diff mbox series

Patch

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index c6098eee0c7c..f1e58de117dc 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -131,7 +131,7 @@  config BCM7120_L2_IRQ
 	select IRQ_DOMAIN
 
 config BRCMSTB_L2_IRQ
-	bool
+	bool "Broadcom STB L2 Interrupt Controller"
 	select GENERIC_IRQ_CHIP
 	select IRQ_DOMAIN