diff mbox series

[01/27] arm64: dts: mt8195: add infracfg_rst node

Message ID 20210615173233.26682-2-tinghan.shen@mediatek.com
State New
Headers show
Series [01/27] arm64: dts: mt8195: add infracfg_rst node | expand

Commit Message

Tinghan Shen June 15, 2021, 5:32 p.m. UTC
From: Crystal Guo <crystal.guo@mediatek.com>

add infracfg_rst node which is for MT8195 platform

Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8195.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Chen-Yu Tsai June 16, 2021, 8:01 a.m. UTC | #1
Hi,

On Wed, Jun 16, 2021 at 01:32:08AM +0800, Tinghan Shen wrote:
> From: Crystal Guo <crystal.guo@mediatek.com>

> 

> add infracfg_rst node which is for MT8195 platform

> 

> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>

> ---

>  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 15 +++++++++++++++

>  1 file changed, 15 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi

> index 629cd883facf..8cda62f736b3 100644

> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi

> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi

> @@ -8,6 +8,7 @@

>  

>  #include <dt-bindings/interrupt-controller/arm-gic.h>

>  #include <dt-bindings/interrupt-controller/irq.h>

> +#include <dt-bindings/reset/ti-syscon.h>

>  

>  / {

>  	compatible = "mediatek,mt8195";

> @@ -273,6 +274,20 @@

>  			};

>  		};

>  

> +		infracfg: syscon@10001000 {

> +			compatible = "mediatek,mt8195-infracfg", "syscon", "simple-mfd";


This block is named infracfg_ao in the datasheet. You seem to rename it
in the clock patch. Maybe you squashed the change into the wrong commit?

> +			reg = <0 0x10001000 0 0x1000>;


The address range matches the datasheet.

> +			#clock-cells = <1>;

> +

> +			infracfg_rst: reset-controller {

> +				compatible = "ti,syscon-reset";

> +				#reset-cells = <1>;

> +				ti,reset-bits = <

> +					0x140 26 0x144 26 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE)

> +				>;

> +			};


This node doesn't seem to be used anywhere. Is it really needed?


ChenYu
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index 629cd883facf..8cda62f736b3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -8,6 +8,7 @@ 
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/reset/ti-syscon.h>
 
 / {
 	compatible = "mediatek,mt8195";
@@ -273,6 +274,20 @@ 
 			};
 		};
 
+		infracfg: syscon@10001000 {
+			compatible = "mediatek,mt8195-infracfg", "syscon", "simple-mfd";
+			reg = <0 0x10001000 0 0x1000>;
+			#clock-cells = <1>;
+
+			infracfg_rst: reset-controller {
+				compatible = "ti,syscon-reset";
+				#reset-cells = <1>;
+				ti,reset-bits = <
+					0x140 26 0x144 26 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE)
+				>;
+			};
+		};
+
 		watchdog: watchdog@10007000 {
 			compatible = "mediatek,mt8195-wdt", "mediatek,mt6589-wdt";
 			reg = <0 0x10007000 0 0x100>;