diff mbox series

[v2,1/2] leds: tca6507: Get rid of duplicate of_node assignment

Message ID 20211214142739.60071-1-andriy.shevchenko@linux.intel.com
State New
Headers show
Series [v2,1/2] leds: tca6507: Get rid of duplicate of_node assignment | expand

Commit Message

Andy Shevchenko Dec. 14, 2021, 2:27 p.m. UTC
GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Call graph:
   --> tca6507_probe_gpios()
     --> gpiochip_add_data()
       --> gpiochip_add_data_with_key()
         --> of_gpio_dev_init()

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: added call graph to the commit message (Pavel)
 drivers/leds/leds-tca6507.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Pavel Machek Dec. 15, 2021, 8:27 p.m. UTC | #1
On Tue 2021-12-14 16:27:39, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
> 
> For the details one may look into the of_gpio_dev_init()
implementation.

Thank you, applied the series.
								Pavel
Andy Shevchenko Dec. 16, 2021, 2:28 p.m. UTC | #2
On Thu, Dec 16, 2021 at 12:29 AM Pavel Machek <pavel@ucw.cz> wrote:
> On Tue 2021-12-14 16:27:39, Andy Shevchenko wrote:
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove assignment here.
> >
> > For the details one may look into the of_gpio_dev_init()
> implementation.
>
> Thank you, applied the series.

Thanks!
diff mbox series

Patch

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index de8eed9b667d..1473ced8664c 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -641,9 +641,6 @@  static int tca6507_probe_gpios(struct device *dev,
 	tca->gpio.direction_output = tca6507_gpio_direction_output;
 	tca->gpio.set = tca6507_gpio_set_value;
 	tca->gpio.parent = dev;
-#ifdef CONFIG_OF_GPIO
-	tca->gpio.of_node = of_node_get(dev_of_node(dev));
-#endif
 	err = gpiochip_add_data(&tca->gpio, tca);
 	if (err) {
 		tca->gpio.ngpio = 0;