diff mbox series

kselftest: add generated objects to .gitignore

Message ID 20220225102726.3231228-1-usama.anjum@collabora.com
State New
Headers show
Series kselftest: add generated objects to .gitignore | expand

Commit Message

Muhammad Usama Anjum Feb. 25, 2022, 10:27 a.m. UTC
Add kselftests_install directory and some other files to the
.gitignore.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/.gitignore      | 1 +
 tools/testing/selftests/exec/.gitignore | 2 ++
 tools/testing/selftests/kvm/.gitignore  | 1 +
 tools/testing/selftests/net/.gitignore  | 1 +
 4 files changed, 5 insertions(+)

Comments

Shuah Khan Feb. 25, 2022, 11:59 p.m. UTC | #1
On 2/25/22 3:27 AM, Muhammad Usama Anjum wrote:
> Add kselftests_install directory and some other files to the
> .gitignore.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>   tools/testing/selftests/.gitignore      | 1 +
>   tools/testing/selftests/exec/.gitignore | 2 ++
>   tools/testing/selftests/kvm/.gitignore  | 1 +
>   tools/testing/selftests/net/.gitignore  | 1 +
>   4 files changed, 5 insertions(+)
> 

It is better to split these patches per test - makes it easier
to apply. Please send separate patches for each test. This patch
doesn't apply as is.

thanks,
-- Shuah
Kees Cook Feb. 26, 2022, 2:23 a.m. UTC | #2
On Fri, Feb 25, 2022 at 04:59:58PM -0700, Shuah Khan wrote:
> On 2/25/22 3:27 AM, Muhammad Usama Anjum wrote:
> > Add kselftests_install directory and some other files to the
> > .gitignore.
> > 
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> > ---
> >   tools/testing/selftests/.gitignore      | 1 +
> >   tools/testing/selftests/exec/.gitignore | 2 ++
> >   tools/testing/selftests/kvm/.gitignore  | 1 +
> >   tools/testing/selftests/net/.gitignore  | 1 +
> >   4 files changed, 5 insertions(+)
> > 
> 
> It is better to split these patches per test - makes it easier
> to apply. Please send separate patches for each test. This patch
> doesn't apply as is.

Once fixed, please consider them:

Reviewed-by: Kees Cook <keescook@chromium.org>
Jakub Kicinski Feb. 26, 2022, 6:11 a.m. UTC | #3
On Fri, 25 Feb 2022 15:27:25 +0500 Muhammad Usama Anjum wrote:
> diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
> index 21a411b04890..c3a6dc45eff4 100644
> --- a/tools/testing/selftests/net/.gitignore
> +++ b/tools/testing/selftests/net/.gitignore
> @@ -36,3 +36,4 @@ gro
>  ioam6_parser
>  toeplitz
>  cmsg_sender
> +cmsg_so_mark

You probably have stale objects in your tree, cmsg_so_mark was renamed 
to cmsg_sender. This is incorrect.
diff mbox series

Patch

diff --git a/tools/testing/selftests/.gitignore b/tools/testing/selftests/.gitignore
index 055a5019b13c..cb24124ac5b9 100644
--- a/tools/testing/selftests/.gitignore
+++ b/tools/testing/selftests/.gitignore
@@ -3,6 +3,7 @@  gpiogpio-event-mon
 gpiogpio-hammer
 gpioinclude/
 gpiolsgpio
+kselftest_install/
 tpm2/SpaceTest.log
 
 # Python bytecode and cache
diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/selftests/exec/.gitignore
index 9e2f00343f15..2f715782b076 100644
--- a/tools/testing/selftests/exec/.gitignore
+++ b/tools/testing/selftests/exec/.gitignore
@@ -12,3 +12,5 @@  execveat.denatured
 xxxxxxxx*
 pipe
 S_I*.test
+non-regular
+null-argv
diff --git a/tools/testing/selftests/kvm/.gitignore b/tools/testing/selftests/kvm/.gitignore
index 7903580a48ac..4d11adeac214 100644
--- a/tools/testing/selftests/kvm/.gitignore
+++ b/tools/testing/selftests/kvm/.gitignore
@@ -21,6 +21,7 @@ 
 /x86_64/hyperv_clock
 /x86_64/hyperv_cpuid
 /x86_64/hyperv_features
+/x86_64/hyperv_svm_test
 /x86_64/mmio_warning_test
 /x86_64/mmu_role_test
 /x86_64/platform_info_test
diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
index 21a411b04890..c3a6dc45eff4 100644
--- a/tools/testing/selftests/net/.gitignore
+++ b/tools/testing/selftests/net/.gitignore
@@ -36,3 +36,4 @@  gro
 ioam6_parser
 toeplitz
 cmsg_sender
+cmsg_so_mark