diff mbox series

HID: wacom: Simplify comments

Message ID bb1df380b64dd708f480261548fb303046352878.1659296372.git.christophe.jaillet@wanadoo.fr
State New
Headers show
Series HID: wacom: Simplify comments | expand

Commit Message

Christophe JAILLET July 31, 2022, 7:39 p.m. UTC
Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.

While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/hid/wacom_sys.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Gerecke, Jason Aug. 2, 2022, 3:38 p.m. UTC | #1
On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.
>
> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/hid/wacom_sys.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * drivers/input/tablet/wacom_sys.c
> - *
>   *  USB Wacom tablet support - system specific code
>   */
>
> -/*
> - */
> -
>  #include "wacom_wac.h"
>  #include "wacom.h"
>  #include <linux/input/mt.h>
> --
> 2.34.1
>

LGTM.
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
Ping Cheng Aug. 2, 2022, 6:41 p.m. UTC | #2
Hi Christophe,

Thank you for cleaning up the driver code.

On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.

While you are here, can you update your patch to include the removal
of the empty comment blocks and paths in the other three files:
wacom.h, wacom_wac.h, and wacom_wac.c?

Thanks,
Ping

> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/hid/wacom_sys.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * drivers/input/tablet/wacom_sys.c
> - *
>   *  USB Wacom tablet support - system specific code
>   */
>
> -/*
> - */
> -
>  #include "wacom_wac.h"
>  #include "wacom.h"
>  #include <linux/input/mt.h>
> --
> 2.34.1
>
Christophe JAILLET Aug. 2, 2022, 6:47 p.m. UTC | #3
Le 02/08/2022 à 20:41, Ping Cheng a écrit :
> Hi Christophe,
> 
> Thank you for cleaning up the driver code.
> 
> On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>>
>> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
>> boilerplate/reference with SPDX - rule 152").
>> An empty comment block can be removed.
> 
> While you are here, can you update your patch to include the removal
> of the empty comment blocks and paths in the other three files:
> wacom.h, wacom_wac.h, and wacom_wac.c?

I'll send a v2.
Thanks for pointing it out.

CJ


> 
> Thanks,
> Ping
> 
>> While at it remove, also remove what is supposed to be the path/filename of
>> the file.
>> This is really low value... and wrong since commit 471d17148c8b
>> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   drivers/hid/wacom_sys.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
>> index 194a2e327591..21612fdae9c3 100644
>> --- a/drivers/hid/wacom_sys.c
>> +++ b/drivers/hid/wacom_sys.c
>> @@ -1,13 +1,8 @@
>>   // SPDX-License-Identifier: GPL-2.0-or-later
>>   /*
>> - * drivers/input/tablet/wacom_sys.c
>> - *
>>    *  USB Wacom tablet support - system specific code
>>    */
>>
>> -/*
>> - */
>> -
>>   #include "wacom_wac.h"
>>   #include "wacom.h"
>>   #include <linux/input/mt.h>
>> --
>> 2.34.1
>>
>
diff mbox series

Patch

diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@ 
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * drivers/input/tablet/wacom_sys.c
- *
  *  USB Wacom tablet support - system specific code
  */
 
-/*
- */
-
 #include "wacom_wac.h"
 #include "wacom.h"
 #include <linux/input/mt.h>