diff mbox series

[v1,1/1] scsi: ufs: ufs-pci: Switch to use acpi_evaluate_dsm_typed()

Message ID 20231002135125.2602895-1-andriy.shevchenko@linux.intel.com
State New
Headers show
Series [v1,1/1] scsi: ufs: ufs-pci: Switch to use acpi_evaluate_dsm_typed() | expand

Commit Message

Andy Shevchenko Oct. 2, 2023, 1:51 p.m. UTC
The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/ufs/host/ufshcd-pci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Oct. 10, 2023, 1:47 a.m. UTC | #1
Andy,

> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.

Applied to 6.7/scsi-staging, thanks!
Martin K. Petersen Oct. 13, 2023, 9:03 p.m. UTC | #2
On Mon, 02 Oct 2023 16:51:25 +0300, Andy Shevchenko wrote:

> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
> 
> 

Applied to 6.7/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-pci: Switch to use acpi_evaluate_dsm_typed()
      https://git.kernel.org/mkp/scsi/c/fcf3fb7bd50c
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufshcd-pci.c b/drivers/ufs/host/ufshcd-pci.c
index 248a49e5e7f3..0aca666d2199 100644
--- a/drivers/ufs/host/ufshcd-pci.c
+++ b/drivers/ufs/host/ufshcd-pci.c
@@ -58,11 +58,12 @@  static int __intel_dsm(struct intel_host *intel_host, struct device *dev,
 	int err = 0;
 	size_t len;
 
-	obj = acpi_evaluate_dsm(ACPI_HANDLE(dev), &intel_dsm_guid, 0, fn, NULL);
+	obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(dev), &intel_dsm_guid, 0, fn, NULL,
+				      ACPI_TYPE_BUFFER);
 	if (!obj)
 		return -EOPNOTSUPP;
 
-	if (obj->type != ACPI_TYPE_BUFFER || obj->buffer.length < 1) {
+	if (obj->buffer.length < 1) {
 		err = -EINVAL;
 		goto out;
 	}