diff mbox series

scsi: isci: request: Fix an error code problem in isci_io_request_build

Message ID 20240112041926.3924315-1-suhui@nfschina.com
State New
Headers show
Series scsi: isci: request: Fix an error code problem in isci_io_request_build | expand

Commit Message

Su Hui Jan. 12, 2024, 4:19 a.m. UTC
Clang static complains that Value stored to 'status' is never read.
Return 'status' rather than 'SCI_SUCCESS'.

Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
 drivers/scsi/isci/request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Artur Paszkiewicz Jan. 15, 2024, 8:45 a.m. UTC | #1
On 1/12/24 05:19, Su Hui wrote:
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.
> 
> Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
> Signed-off-by: Su Hui <suhui@nfschina.com>

Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
diff mbox series

Patch

diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index 71f711cb0628..355a0bc0828e 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -3387,7 +3387,7 @@  static enum sci_status isci_io_request_build(struct isci_host *ihost,
 		return SCI_FAILURE;
 	}
 
-	return SCI_SUCCESS;
+	return status;
 }
 
 static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)