diff mbox series

wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

Message ID 20240213122556.9593-1-pkshih@realtek.com
State New
Headers show
Series wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured | expand

Commit Message

Ping-Ke Shih Feb. 13, 2024, 12:25 p.m. UTC
The rcu_read_unlock() is accidentally added, and sparse warn:

  drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
    warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock

Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/fw.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Feb. 15, 2024, 11:10 a.m. UTC | #1
Ping-Ke Shih <pkshih@realtek.com> wrote:

> The rcu_read_unlock() is accidentally added, and sparse warn:
> 
>   drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
>     warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock
> 
> Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
> Cc: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

63d94f749623 wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 540ea16f048e..7f0c8cfb3e2d 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -2808,7 +2808,6 @@  int rtw89_fw_h2c_assoc_cmac_tbl_g7(struct rtw89_dev *rtwdev,
 
 		h2c->w4 |= le32_encode_bits(~punct,
 					    CCTLINFO_G7_W4_ACT_SUBCH_CBW);
-		rcu_read_unlock();
 		h2c->m4 |= cpu_to_le32(CCTLINFO_G7_W4_ACT_SUBCH_CBW);
 	}