diff mbox series

KEYS: asymmetric: Add missing dependency on CRYPTO_SIG

Message ID 20240422210845.319819-1-ebiggers@kernel.org
State New
Headers show
Series KEYS: asymmetric: Add missing dependency on CRYPTO_SIG | expand

Commit Message

Eric Biggers April 22, 2024, 9:08 p.m. UTC
From: Eric Biggers <ebiggers@google.com>

Make ASYMMETRIC_PUBLIC_KEY_SUBTYPE select CRYPTO_SIG to avoid build
errors like the following, which were possible with
CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y && CONFIG_CRYPTO_SIG=n:

    ld: vmlinux.o: in function `public_key_verify_signature':
    (.text+0x306280): undefined reference to `crypto_alloc_sig'
    ld: (.text+0x306300): undefined reference to `crypto_sig_set_pubkey'
    ld: (.text+0x306324): undefined reference to `crypto_sig_verify'
    ld: (.text+0x30636c): undefined reference to `crypto_sig_set_privkey'

Fixes: 63ba4d67594a ("KEYS: asymmetric: Use new crypto interface without scatterlists")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/asymmetric_keys/Kconfig | 1 +
 1 file changed, 1 insertion(+)


base-commit: ed30a4a51bb196781c8058073ea720133a65596f

Comments

Jarkko Sakkinen April 23, 2024, 9:51 p.m. UTC | #1
On Wed Apr 24, 2024 at 12:49 AM EEST, Jarkko Sakkinen wrote:
> On Tue Apr 23, 2024 at 12:08 AM EEST, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Make ASYMMETRIC_PUBLIC_KEY_SUBTYPE select CRYPTO_SIG to avoid build
> > errors like the following, which were possible with
> > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y && CONFIG_CRYPTO_SIG=n:
> >
> >     ld: vmlinux.o: in function `public_key_verify_signature':
> >     (.text+0x306280): undefined reference to `crypto_alloc_sig'
> >     ld: (.text+0x306300): undefined reference to `crypto_sig_set_pubkey'
> >     ld: (.text+0x306324): undefined reference to `crypto_sig_verify'
> >     ld: (.text+0x30636c): undefined reference to `crypto_sig_set_privkey'
> >
> > Fixes: 63ba4d67594a ("KEYS: asymmetric: Use new crypto interface without scatterlists")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >  crypto/asymmetric_keys/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> > index 59ec726b7c77..3f089abd6fc9 100644
> > --- a/crypto/asymmetric_keys/Kconfig
> > +++ b/crypto/asymmetric_keys/Kconfig
> > @@ -13,10 +13,11 @@ if ASYMMETRIC_KEY_TYPE
> >  config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
> >  	tristate "Asymmetric public-key crypto algorithm subtype"
> >  	select MPILIB
> >  	select CRYPTO_HASH_INFO
> >  	select CRYPTO_AKCIPHER
> > +	select CRYPTO_SIG
> >  	select CRYPTO_HASH
> >  	help
> >  	  This option provides support for asymmetric public key type handling.
> >  	  If signature generation and/or verification are to be used,
> >  	  appropriate hash algorithms (such as SHA-1) must be available.
> >
> > base-commit: ed30a4a51bb196781c8058073ea720133a65596f
>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> BR, Jarkko

Picked.

BR, Jarkko
diff mbox series

Patch

diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
index 59ec726b7c77..3f089abd6fc9 100644
--- a/crypto/asymmetric_keys/Kconfig
+++ b/crypto/asymmetric_keys/Kconfig
@@ -13,10 +13,11 @@  if ASYMMETRIC_KEY_TYPE
 config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
 	tristate "Asymmetric public-key crypto algorithm subtype"
 	select MPILIB
 	select CRYPTO_HASH_INFO
 	select CRYPTO_AKCIPHER
+	select CRYPTO_SIG
 	select CRYPTO_HASH
 	help
 	  This option provides support for asymmetric public key type handling.
 	  If signature generation and/or verification are to be used,
 	  appropriate hash algorithms (such as SHA-1) must be available.