diff mbox series

selftests/kcmp: Remove unused open mode

Message ID 20240429234610.191144-1-edliaw@google.com
State New
Headers show
Series selftests/kcmp: Remove unused open mode | expand

Commit Message

Edward Liaw April 29, 2024, 11:46 p.m. UTC
Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
aren't specified.  The permissions for the file are set above:

	fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);

Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/kcmp/kcmp_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cyrill Gorcunov April 30, 2024, 5:47 p.m. UTC | #1
On Mon, Apr 29, 2024 at 11:46:09PM +0000, Edward Liaw wrote:
> Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
> aren't specified.  The permissions for the file are set above:
> 
> 	fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);
> 
> Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
> Signed-off-by: Edward Liaw <edliaw@google.com>

Thanks!

Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
diff mbox series

Patch

diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c
index 25110c7c0b3e..d7a8e321bb16 100644
--- a/tools/testing/selftests/kcmp/kcmp_test.c
+++ b/tools/testing/selftests/kcmp/kcmp_test.c
@@ -91,7 +91,7 @@  int main(int argc, char **argv)
 		ksft_print_header();
 		ksft_set_plan(3);
 
-		fd2 = open(kpath, O_RDWR, 0644);
+		fd2 = open(kpath, O_RDWR);
 		if (fd2 < 0) {
 			perror("Can't open file");
 			ksft_exit_fail();