| Message ID | 20240514180046.543763-1-quic_uchalich@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | firmware: qcom-scm: Remove QCOM_SMC_WAITQ_FLAG_WAKE_ALL | expand |
On Tue, May 14, 2024 at 11:00:46AM -0700, Unnathi Chalicheemala wrote: > This flag was never supported by firmware, so remove it. > > Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com> Reviewed-by: Elliot Berman <quic_eberman@quicinc.com> > --- > drivers/firmware/qcom/qcom_scm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > index 68f4df7e6c3c..d511ede6f172 100644 > --- a/drivers/firmware/qcom/qcom_scm.c > +++ b/drivers/firmware/qcom/qcom_scm.c > @@ -114,7 +114,6 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_MAX_CPUS] = { > }; > > #define QCOM_SMC_WAITQ_FLAG_WAKE_ONE BIT(0) > -#define QCOM_SMC_WAITQ_FLAG_WAKE_ALL BIT(1) > > #define QCOM_DLOAD_MASK GENMASK(5, 4) > #define QCOM_DLOAD_NODUMP 0 > @@ -1793,9 +1792,8 @@ static irqreturn_t qcom_scm_irq_handler(int irq, void *data) > goto out; > } > > - if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE && > - flags != QCOM_SMC_WAITQ_FLAG_WAKE_ALL) { > - dev_err(scm->dev, "Invalid flags found for wq_ctx: %u\n", flags); > + if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE) { > + dev_err(scm->dev, "Invalid flags received for wq_ctx: %u\n", flags); > goto out; > } > > -- > 2.34.1 >
On Tue, 14 May 2024 11:00:46 -0700, Unnathi Chalicheemala wrote: > This flag was never supported by firmware, so remove it. > > Applied, thanks! [1/1] firmware: qcom-scm: Remove QCOM_SMC_WAITQ_FLAG_WAKE_ALL commit: f63f815fc2a5ca9d57beba0286aaa82bc3277353 Best regards,
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 68f4df7e6c3c..d511ede6f172 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -114,7 +114,6 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_MAX_CPUS] = { }; #define QCOM_SMC_WAITQ_FLAG_WAKE_ONE BIT(0) -#define QCOM_SMC_WAITQ_FLAG_WAKE_ALL BIT(1) #define QCOM_DLOAD_MASK GENMASK(5, 4) #define QCOM_DLOAD_NODUMP 0 @@ -1793,9 +1792,8 @@ static irqreturn_t qcom_scm_irq_handler(int irq, void *data) goto out; } - if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE && - flags != QCOM_SMC_WAITQ_FLAG_WAKE_ALL) { - dev_err(scm->dev, "Invalid flags found for wq_ctx: %u\n", flags); + if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE) { + dev_err(scm->dev, "Invalid flags received for wq_ctx: %u\n", flags); goto out; }
This flag was never supported by firmware, so remove it. Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com> --- drivers/firmware/qcom/qcom_scm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)