| Message ID | 20240516044537.16801-3-r-gunasekaran@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | TI AM64/J7: USB Errata i2409 workaround | expand |
On 24-05-16 10:15:37, Ravi Gunasekaran wrote: > From: Roger Quadros <rogerq@kernel.org> > > TI USB2 PHY is known to have a lockup issue on very short > suspend intervals. Enable the Suspend Residency quirk flag to > workaround this as described in Errata i2409 [1]. > > [1] - https://www.ti.com/lit/er/sprz457h/sprz457h.pdf > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > Change log: > ---------- > Changes since v2: > ---------------- > * No change > > Changes since v1: > ---------------- > * No change > > v2: https://lore.kernel.org/all/20240516042845.31211-1-r-gunasekaran@ti.com/ > v1: https://lore.kernel.org/all/20240514092421.20897-1-r-gunasekaran@ti.com/#t > > drivers/usb/cdns3/cdns3-ti.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c > index 5945c4b1e11f..cfabc12ee0e3 100644 > --- a/drivers/usb/cdns3/cdns3-ti.c > +++ b/drivers/usb/cdns3/cdns3-ti.c > @@ -16,6 +16,7 @@ > #include <linux/of_platform.h> > #include <linux/pm_runtime.h> > #include <linux/property.h> > +#include "core.h" > > /* USB Wrapper register offsets */ > #define USBSS_PID 0x0 > @@ -85,6 +86,18 @@ static inline void cdns_ti_writel(struct cdns_ti *data, u32 offset, u32 value) > writel(value, data->usbss + offset); > } > > +static struct cdns3_platform_data cdns_ti_pdata = { > + .quirks = CDNS3_DRD_SUSPEND_RESIDENCY_ENABLE, /* Errata i2409 */ > +}; > + > +static const struct of_dev_auxdata cdns_ti_auxdata[] = { > + { > + .compatible = "cdns,usb3", > + .platform_data = &cdns_ti_pdata, > + }, > + {}, > +}; > + > static int cdns_ti_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -176,7 +189,7 @@ static int cdns_ti_probe(struct platform_device *pdev) > reg |= USBSS_W1_PWRUP_RST; > cdns_ti_writel(data, USBSS_W1, reg); > > - error = of_platform_populate(node, NULL, NULL, dev); > + error = of_platform_populate(node, NULL, cdns_ti_auxdata, dev); > if (error) { > dev_err(dev, "failed to create children: %d\n", error); > goto err; > -- > 2.17.1 > Acked-by: Peter Chen <peter.chen@kernel.org>
diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c index 5945c4b1e11f..cfabc12ee0e3 100644 --- a/drivers/usb/cdns3/cdns3-ti.c +++ b/drivers/usb/cdns3/cdns3-ti.c @@ -16,6 +16,7 @@ #include <linux/of_platform.h> #include <linux/pm_runtime.h> #include <linux/property.h> +#include "core.h" /* USB Wrapper register offsets */ #define USBSS_PID 0x0 @@ -85,6 +86,18 @@ static inline void cdns_ti_writel(struct cdns_ti *data, u32 offset, u32 value) writel(value, data->usbss + offset); } +static struct cdns3_platform_data cdns_ti_pdata = { + .quirks = CDNS3_DRD_SUSPEND_RESIDENCY_ENABLE, /* Errata i2409 */ +}; + +static const struct of_dev_auxdata cdns_ti_auxdata[] = { + { + .compatible = "cdns,usb3", + .platform_data = &cdns_ti_pdata, + }, + {}, +}; + static int cdns_ti_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -176,7 +189,7 @@ static int cdns_ti_probe(struct platform_device *pdev) reg |= USBSS_W1_PWRUP_RST; cdns_ti_writel(data, USBSS_W1, reg); - error = of_platform_populate(node, NULL, NULL, dev); + error = of_platform_populate(node, NULL, cdns_ti_auxdata, dev); if (error) { dev_err(dev, "failed to create children: %d\n", error); goto err;