mbox series

[0/3] arm64: dts: qcom: x1e80100: Fix the data-lanes and link-frequencies

Message ID 20240418-x1e80100-dts-fix-mdss-dp3-v1-0-9f8420e395d4@linaro.org
Headers show
Series arm64: dts: qcom: x1e80100: Fix the data-lanes and link-frequencies | expand

Message

Abel Vesa April 18, 2024, 10:22 a.m. UTC
Both the CRD and the QCP have the data-lanes and the link-frequencies
for the DP3 in the wrong place. Both are properties of the out remote
endpoint. So move them to the mdss_dp3_out for each board.

Without these fixes, the eDP is broken on both boards.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (3):
      arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in
      arm64: dts: qcom: x1e80100-crd: Add data-lanes and link-frequencies to DP3
      arm64: dts: qcom: x1e80100-qcp: Add data-lanes and link-frequencies to DP3

 arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 5 +++--
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 5 +++--
 arch/arm64/boot/dts/qcom/x1e80100.dtsi    | 1 -
 3 files changed, 6 insertions(+), 5 deletions(-)
---
base-commit: 4eab358930711bbeb85bf5ee267d0d42d3394c2c
change-id: 20240418-x1e80100-dts-fix-mdss-dp3-c2345ee3ee2f

Best regards,

Comments

Abel Vesa April 19, 2024, 4:03 p.m. UTC | #1
On 24-04-18 08:57:37, Bjorn Andersson wrote:
> On Thu, Apr 18, 2024 at 01:22:18PM +0300, Abel Vesa wrote:
> > The link-frequences belong in mdss_dp3_out. Display is broken because of
> > this. Drop them from mdss_dp3_in.
> > 
> 
> Why is display broken because you have this property in the wrong node?
> Isn't it broken because you don't have it in &mdss_dp3_out and this is
> just a cleanup of an invalid property?
> 
> Perhaps that's what you're trying to say? Would be nice to have that
> clarified.

Will drop the "Display is broken because of this." part.

Thanks.

> 
> Regards,
> Bjorn
> 
> > Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index f5a3b39ae70e..0642b5e88639 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -4096,7 +4096,6 @@ port@0 {
> >  						mdss_dp3_in: endpoint {
> >  							remote-endpoint = <&mdss_intf5_out>;
> >  
> > -							link-frequencies = /bits/ 64 <8100000000>;
> >  						};
> >  					};
> >  
> > 
> > -- 
> > 2.34.1
> >