diff mbox series

[v3,4/4] dt-bindings: PCI: mediatek,mt7621-pcie: switch from deprecated pci-bus.yaml

Message ID 20240413151617.35630-4-krzysztof.kozlowski@linaro.org
State Accepted
Commit d3fa4be9033b7b042b3ee9f5e1fc5c44735716b4
Headers show
Series [v3,1/4] dt-bindings: PCI: cdns,cdns-pcie-host: drop redundant msi-parent and pci-bus.yaml | expand

Commit Message

Krzysztof Kozlowski April 13, 2024, 3:16 p.m. UTC
dtschema package with core schemas deprecated pci-bus.yaml schema in
favor of individual schemas per host, device and pci-pci.

Switch Mediatek MT7621 PCIe host bridge binding to this new schema.

This requires dtschema package newer than v2024.02 to work fully.
v2024.02 will partially work: with a warning.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Important: This depends on change recently merged to dtschema, however
no release was yet made with mentioned change.
Therefore this patch probably should wait a bit. Previous patches do not
depend anyhow on future release, so they can be taken as is.

Changes in v3:
1. None

Changes in v2:
1. New patch
2. Split mediatek,mt7621-pcie to separate patch as it uses
   pci-pci-bridge schema.
---
 .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sergio Paracuellos April 15, 2024, 7:31 a.m. UTC | #1
Hi Krzysztof,

On Sat, Apr 13, 2024 at 5:16 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of individual schemas per host, device and pci-pci.
>
> Switch Mediatek MT7621 PCIe host bridge binding to this new schema.
>
> This requires dtschema package newer than v2024.02 to work fully.
> v2024.02 will partially work: with a warning.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Important: This depends on change recently merged to dtschema, however
> no release was yet made with mentioned change.
> Therefore this patch probably should wait a bit. Previous patches do not
> depend anyhow on future release, so they can be taken as is.

Does this mean that we should set DT_SCHEMA_MIN_VERSION to 2024.02 in
Documentation/devicetree/bindings/Makefile then before merging this
patch?

>
> Changes in v3:
> 1. None
>
> Changes in v2:
> 1. New patch
> 2. Split mediatek,mt7621-pcie to separate patch as it uses
>    pci-pci-bridge schema.
> ---
>  .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml         | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos
Krzysztof Kozlowski April 15, 2024, 7:45 a.m. UTC | #2
On 15/04/2024 09:31, Sergio Paracuellos wrote:
> Hi Krzysztof,
> 
> On Sat, Apr 13, 2024 at 5:16 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> dtschema package with core schemas deprecated pci-bus.yaml schema in
>> favor of individual schemas per host, device and pci-pci.
>>
>> Switch Mediatek MT7621 PCIe host bridge binding to this new schema.
>>
>> This requires dtschema package newer than v2024.02 to work fully.
>> v2024.02 will partially work: with a warning.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Important: This depends on change recently merged to dtschema, however
>> no release was yet made with mentioned change.
>> Therefore this patch probably should wait a bit. Previous patches do not
>> depend anyhow on future release, so they can be taken as is.
> 
> Does this mean that we should set DT_SCHEMA_MIN_VERSION to 2024.02 in
> Documentation/devicetree/bindings/Makefile then before merging this
> patch?

For the previous changes: yes. For this one: we need newer...
Best regards,
Krzysztof
AngeloGioacchino Del Regno April 15, 2024, 10:43 a.m. UTC | #3
Il 13/04/24 17:16, Krzysztof Kozlowski ha scritto:
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of individual schemas per host, device and pci-pci.
> 
> Switch Mediatek MT7621 PCIe host bridge binding to this new schema.
> 
> This requires dtschema package newer than v2024.02 to work fully.
> v2024.02 will partially work: with a warning.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
index 61d027239910..6fba42156db6 100644
--- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
@@ -14,7 +14,7 @@  description: |+
   with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
 
 allOf:
-  - $ref: /schemas/pci/pci-bus.yaml#
+  - $ref: /schemas/pci/pci-host-bridge.yaml#
 
 properties:
   compatible:
@@ -33,7 +33,7 @@  properties:
 patternProperties:
   '^pcie@[0-2],0$':
     type: object
-    $ref: /schemas/pci/pci-bus.yaml#
+    $ref: /schemas/pci/pci-pci-bridge.yaml#
 
     properties:
       reg: