From patchwork Fri Mar 22 01:08:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Tymoshenko X-Patchwork-Id: 782277 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FC7065C for ; Fri, 22 Mar 2024 01:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711069738; cv=none; b=XLQMxVusqtUOFj2dID3mC8Jlxdi8pjXpfBMRjLBxy97+11rF3XQP0CGV5pZZbkTlwi7V4oXPHSYkyuj+ylygq6uP/hPvHST39v5Qn4ulhnZIXVatDALMhxpkPGbG2LHfu9uaXYH3dceXSMJtmbZl9Sj9KNibdFzXNTytzUd5W0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711069738; c=relaxed/simple; bh=OfGge7sG/ns1z/ItuB0Kcv1DpFj1OPQ1tPMi+jFOVOY=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=GH8Lowi14QKBFlcjdIIrLd+284yx4xx7/ScYag//xqwmDAhjc0mdMPeJz3uEtDDv2M4EaC0DGpzXkfMWnG3CuCKaQCE3w/5uwEnGKWpKHfHR/PmRN+CsXZbE3Ck/5tsqbLHIQUnGYdWPlW43KvYfvvABFV6evjqi9u6CB1oLtw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ovt.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=d7xuTVW4; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ovt.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="d7xuTVW4" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-5d8dbe37d56so1017405a12.0 for ; Thu, 21 Mar 2024 18:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711069736; x=1711674536; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=R+y1XoQi4L4pB9dXi4cPQL39QfY+GN+c/qrd7Sy4OvU=; b=d7xuTVW4SivG0vyvTbUrFEYr01NbbEUBtkH4uBkO6ZrgJ4tYWvxmSYu18KALSeZ3KU Xl7B+uTpwlEVEU3tMZZcYn5yoWQ2MM0w20cFG3f4hT5QZIUyJroswo6N3BE5WEQ60Oeg SINPIKbK7Fhihup7EcNQ2/Eqy6uOMFwpGqdUteKhe1/EHtyHirrVZjgqfEAA23HdLrn0 /TIwwUae3La8LNJLLHBEzT2SrYUScU6ZnD8aAPcS1T1/opMjblS65ot21d5/hjxlllq9 0J6wqyMMcuq+F1Qdp6atUVqO+E1kCRz8uyrO7UVpXgVVhkCbmKY289UrXBJtwzp0xRbi 1F7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711069736; x=1711674536; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R+y1XoQi4L4pB9dXi4cPQL39QfY+GN+c/qrd7Sy4OvU=; b=d42Xagq5KMGQ/K409vcLW5yfyJdHCVGjhxwNTON/9dDYzdC1XEARI9/8ALm5L16tkF MWLdY9IdFlM0l7gCYSUSLZxf1tFWb4j9FXs0ZtqQjjTMCt1OIBROt2RzOpn9i38o5i+R 4faIFVdnFflATVryfWtAZBzhX12JC7IVid6zyvK3We1DU8CWgHswPy7/TurPMDK6dcQX MWwnts0o5PS1ljk7bU7XHH6IL5wy02IXi0eqVTv0YkbKT4xzhBQg+deBqElP/4L5sh19 8OLhm7sp7SLp+5ABnHdzkWBY6qbbnYlZ63Iq0cSsTmS6dUkefDn5jDxd2A2eDzyKPCZw Rojw== X-Forwarded-Encrypted: i=1; AJvYcCVagf2K65QihDryhlooJszfqjBY2CVfCsfYJnYDVufUMVt0NFA+MwO/IICijGQp1OXEtl1FAuyEMYVN9xFOcHbA6ICuapbpS6Pt X-Gm-Message-State: AOJu0YzY+zpc4SpttW84a+CFHf0ULDqbOuU/a4mJxqyOV3Qz4qn9FiyN YQI5zuiL7eD5mdtwyIS3YRZCirQCW11ntiIrRWcX+wv7rnTypt314IFgyG2ANPQTbg== X-Google-Smtp-Source: AGHT+IHfIQh71vgw10rr70rB9vqV/a/XdtF6keIbStJjf3iqaWb8qzS0oZN3PCrqBe/2yKDiiHU1ezg= X-Received: from hmarynka.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:925]) (user=ovt job=sendgmr) by 2002:a63:d30a:0:b0:5d3:832c:4048 with SMTP id b10-20020a63d30a000000b005d3832c4048mr2276pgg.9.1711069736318; Thu, 21 Mar 2024 18:08:56 -0700 (PDT) Date: Fri, 22 Mar 2024 01:08:45 +0000 Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.396.g6e790dbe36-goog Message-ID: <20240322010846.305860-1-ovt@google.com> Subject: [PATCH] efi: fix panic in kdump kernel From: Oleksandr Tymoshenko To: Ard Biesheuvel Cc: ovt@google.com, johan+linaro@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Check if get_next_variable() is actually valid pointer before calling it. In kdump kernel this method is set to NULL that causes panic during the kexec-ed kernel boot. Tested with QEMU and OVMF firmware. Signed-off-by: Oleksandr Tymoshenko --- drivers/firmware/efi/efi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index 8859fb0b006d..800b85807a02 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -203,6 +203,8 @@ static bool generic_ops_supported(void) name_size = sizeof(name); + if (efi.get_next_variable == NULL) + return false; status = efi.get_next_variable(&name_size, &name, &guid); if (status == EFI_UNSUPPORTED) return false;