mbox series

[v2,0/2] arm64: dts: allwinner: H616: Add LRADC

Message ID 20240426092924.15489-1-jamcgregor@protonmail.com
Headers show
Series arm64: dts: allwinner: H616: Add LRADC | expand

Message

James McGregor April 26, 2024, 9:29 a.m. UTC 
Version 2 moves the LRADC DT node to the right place. It was out of
order before.

The Allwinner H616 series of SoCs have a low-rate ADC (LRADC) with
6-bit resolution and one input channel. They're compatible with the
existing drivers, so it only needs to be enabled in the DT.

Add an LRADC node to the H616 .dtsi, so board DTs can use them by
adding 'status = "okay";'.

This was tested on an OrangePi Zero 2W by attaching an expansion board
with two key buttons connected to the LRADC, and adding them to the DT.
/dev/input/event0 then properly reported the button presses. The patches
are based off sunxi/for-next.

James McGregor (2):
  dt-bindings: input: sun4i-lradc-keys: Add H616 compatible
  ARM: dts: sun50i: Add LRADC node

 .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml |  4 +++-
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi         | 10 ++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) April 26, 2024, 3:36 p.m. UTC | #1 
On Fri, 26 Apr 2024 09:29:41 +0000, James McGregor wrote:
> The Allwinner H616 SoC has an LRADC which is compatible with the
> versions in existing SoCs.
> Add a compatible string for H616, with the R329 fallback. This is the
> same as the D1, so put them into an enum.
> 
> Signed-off-by: James McGregor <jamcgregor@protonmail.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml        | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Missing tags:

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Chen-Yu Tsai May 28, 2024, 3:42 p.m. UTC | #2 
On Fri, 26 Apr 2024 09:29:37 +0000, James McGregor wrote:
> Version 2 moves the LRADC DT node to the right place. It was out of
> order before.
> 
> The Allwinner H616 series of SoCs have a low-rate ADC (LRADC) with
> 6-bit resolution and one input channel. They're compatible with the
> existing drivers, so it only needs to be enabled in the DT.
> 
> [...]

Applied to sunxi/dt-for-6.11 in sunxi/linux.git, thanks!

[1/2] dt-bindings: input: sun4i-lradc-keys: Add H616 compatible
      https://git.kernel.org/sunxi/linux/c/3086803a1f43
[2/2] ARM: dts: sun50i: Add LRADC node
      https://git.kernel.org/sunxi/linux/c/7adc2d68f4a6

Best regards,
Chen-Yu Tsai May 28, 2024, 4:18 p.m. UTC | #3 
On Tue, May 28, 2024 at 11:42 PM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Fri, 26 Apr 2024 09:29:37 +0000, James McGregor wrote:
> > Version 2 moves the LRADC DT node to the right place. It was out of
> > order before.
> >
> > The Allwinner H616 series of SoCs have a low-rate ADC (LRADC) with
> > 6-bit resolution and one input channel. They're compatible with the
> > existing drivers, so it only needs to be enabled in the DT.
> >
> > [...]
>
> Applied to sunxi/dt-for-6.11 in sunxi/linux.git, thanks!
>
> [1/2] dt-bindings: input: sun4i-lradc-keys: Add H616 compatible
>       https://git.kernel.org/sunxi/linux/c/3086803a1f43
> [2/2] ARM: dts: sun50i: Add LRADC node
>       https://git.kernel.org/sunxi/linux/c/7adc2d68f4a6

I had to do a quick rebase as the branch start point was incorrect. The
commit hashes will have changed. Rest assured that the patch is indeed
merged.


ChenYu