From patchwork Mon Sep 27 14:10:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 514717 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp4158639jao; Mon, 27 Sep 2021 07:11:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlq7bTsvzo9u3ARDy/KjV0IsSM4DPlyalPkT7Bb3LwVzoGvKRilANXtyYC5JPLBoZf21TW X-Received: by 2002:a05:6820:17a:: with SMTP id k26mr90381ood.37.1632751879896; Mon, 27 Sep 2021 07:11:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632751879; cv=none; d=google.com; s=arc-20160816; b=WzrC+apPga3voJvSA0SpZvuKSl2PIRDDZzsWBVqXweKR7Y2dw/g7ScUaoq4WdCoPtU y21LiS41xsN4OU4qMKiRfopiJrzH5gKc695mA2G6DcBvHuPzvDsUXKJgFc97uxoWM+D8 wjDnO3JTjPgpE/M0fd7/PKNIy2q/940a/Xt236WaI5TQEwAJi0xVrEwmamt5Mz+HKSYD AxpsdX2bgKjf3O8Ecq2jbdMRlyFtFsmyDVvThwXn70KZmwmNHoBYP8CgiMHiMr8glH4B Qxf5yhV+ED8Fkld9RRiFd+keNqIOCawq71oiKvrdByyiRT1sP16yd3cDs3mSGS5SgCji Z/pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dkim-signature; bh=TETpCTb6ZdNIINkKGeRqB+yC/R85CEEijxVMMLR2x04=; b=uCJI4JImU2ZJZvB+iKAFI+lpvFH/edT9fNvnqLgG6CsRkMWs8pNBUxeK+tHDThuXBW Dwkz4mfDICRfXePBtzDGLgrc0uXiTr0ClPJybUdGXvZn6Q0MUUM0PMt+UGOB4P2Vbaya agsAmReOSSGXCZ88BVzxHAvHx3aUkB+P0GHbbYhJIR0fHlpSM7SB1syxAxWdtUyt/eR1 9TCRkk7D7QIQAfQ7ZWfw1lJYfp6WbYtBAXY6BUzPX5CKE9USkcv3nYEJQaIOUF1pTgl/ IMb3JQAzCNY//UrSnx4Ph+yIbvB3Gko32Iq5Kk+dy+jpRdNGTjvSMMM4WH67GJqK3nln NEMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b="dQs6I/Ew"; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b="o/pHsBWf"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id n21si6465732otf.169.2021.09.27.07.11.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 07:11:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b="dQs6I/Ew"; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b="o/pHsBWf"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TETpCTb6ZdNIINkKGeRqB+yC/R85CEEijxVMMLR2x04=; b=dQs6I/EwbZIqce HcuSd6Fg2wBGUoz06ne+CU+XTt5pfDlhoXe9n7avuwFu45SAPtOFZesovlTkoqHNUH6p50fP9X2YV B6Rc7BmR51LyPAy+I3yT+yIVxuTdDZg/zPdDoLS2ViAiY8+xaIcdCzKEodbD6sHzdULgETl11qUNh Ey2vQBe6NY1YD27BUe0R3beW+TkxuUruu6RH65TUCPt0hetqKKB1ZNco14jSwf5t0Wl2txKdRmjV6 BpYYTsUvS90T0ldCPAKtW3oyHdPJFldYFKHi2aOtPZy/9RtVkT45KMBptgj9U+xHsnlLCq4Em95nI aoeXPavFXMzVrrZcHNVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUrLK-002rPd-0V; Mon, 27 Sep 2021 14:10:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUrLG-002rP0-Ng for linux-mtd@lists.infradead.org; Mon, 27 Sep 2021 14:10:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5DEA760F94; Mon, 27 Sep 2021 14:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632751850; bh=i+bavvwQSsZR/U2SSCUdxSOShS7k+cqLTQgJdlk5IC8=; h=From:To:Cc:Subject:Date:From; b=o/pHsBWfcf3iVLu+gS9z4G9+dsiEq3G89a8BmNR1uDI5utMJLc3P+zqcY2f8K80Ga 222m135Pjl2LSUsQE8wBNHS2Mu9Qm7UKwkKhl5g+TmAlF0QsRjwsAOl/9L8bp83fc4 YPTstuBjtKWe7l7wnAeztelZ9JrCK2sIFeWl6/NygMTukNT4Oan0SnD0fosC0uAWn4 vms4GHpHJj3lbF1u+rurpBhgFZxTW/5kzcDLCL0jQwEi7+1sBYhR+Swo+TpfhBa0JI C7AxpPH96ijl0WVt6Cxz0+nOBp7/vfv4//itZ53thmYOptaMn02kAgdKbBxZ7GpkQO WO/tHMDlJCZxg== From: Arnd Bergmann To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: Linus Walleij , Imre Kaloz , Krzysztof Halasa , Arnd Bergmann , Lukas Bulwahn , Serge Semin , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] [RFC] mtd: fixup CFI on ixp4xx Date: Mon, 27 Sep 2021 16:10:37 +0200 Message-Id: <20210927141045.1597593-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_071050_821231_20F074D8 X-CRM114-Status: GOOD ( 13.27 ) X-Spam-Score: -5.4 (-----) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arnd Bergmann drivers/mtd/maps/ixp4xx.c requires MTD_CFI_BE_BYTE_SWAP to be set in order to compile. drivers/mtd/maps/ixp4xx.c:57:4: error: #error CONFIG_MTD_CFI_BE_BYTE_SWAP required Content analysis details: (-5.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org From: Arnd Bergmann drivers/mtd/maps/ixp4xx.c requires MTD_CFI_BE_BYTE_SWAP to be set in order to compile. drivers/mtd/maps/ixp4xx.c:57:4: error: #error CONFIG_MTD_CFI_BE_BYTE_SWAP required This patch avoids the #error output by enforcing the policy in Kconfig. Not sure if this is the right approach, but it helps doing randconfig builds. Signed-off-by: Arnd Bergmann --- Any other ideas for how to address it? --- drivers/mtd/chips/Kconfig | 2 ++ drivers/mtd/maps/Kconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.29.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ Acked-by: Linus Walleij diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig index aef14990e5f7..19726ebd973d 100644 --- a/drivers/mtd/chips/Kconfig +++ b/drivers/mtd/chips/Kconfig @@ -55,12 +55,14 @@ choice LITTLE_ENDIAN_BYTE, if the bytes are reversed. config MTD_CFI_NOSWAP + depends on !ARCH_IXP4XX || CPU_BIG_ENDIAN bool "NO" config MTD_CFI_BE_BYTE_SWAP bool "BIG_ENDIAN_BYTE" config MTD_CFI_LE_BYTE_SWAP + depends on !ARCH_IXP4XX bool "LITTLE_ENDIAN_BYTE" endchoice diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig index aaa164b977fe..4945caa88345 100644 --- a/drivers/mtd/maps/Kconfig +++ b/drivers/mtd/maps/Kconfig @@ -302,7 +302,7 @@ config MTD_DC21285 config MTD_IXP4XX tristate "CFI Flash device mapped on Intel IXP4xx based systems" - depends on MTD_CFI && MTD_COMPLEX_MAPPINGS && ARCH_IXP4XX + depends on MTD_CFI && MTD_COMPLEX_MAPPINGS && ARCH_IXP4XX && MTD_CFI_ADV_OPTIONS help This enables MTD access to flash devices on platforms based on Intel's IXP4xx family of network processors such as the