mbox series

[0/1] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND

Message ID 20240428144541.80812-1-rilian.la.te@ya.ru
Headers show
Series serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND | expand

Message

Konstantin Pugin April 28, 2024, 2:45 p.m. UTC
When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration,
we get the following warning after commit 4afeced55baa ("serial: core:
fix sanitizing check for RTS settings"):

    invalid RTS setting, using RTS_AFTER_SEND instead

This results in SER_RS485_RTS_AFTER_SEND being set and the
driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT,
which breaks some hardware using these chips.

The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix
this by announcing support for RTS_ON_SEND.

This patch is extracted from my XR20M117X series as it is affect all SC16IS7XX hardware.
This bug affects all kernel series from 6.1 onwards.

Konstantin Pugin (1):
  serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND

 drivers/tty/serial/sc16is7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 660a708098569a66a47d0abdad998e29e1259de6