From patchwork Thu Jul 31 11:53:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 'Timothy Arceri' via Patchwork Forward X-Patchwork-Id: 34584 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f72.google.com (mail-yh0-f72.google.com [209.85.213.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E245020540 for ; Thu, 31 Jul 2014 11:54:19 +0000 (UTC) Received: by mail-yh0-f72.google.com with SMTP id f73sf9128908yha.7 for ; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list :reply-to:content-type:content-transfer-encoding; bh=hxl4VT3KwTEp3lUV5bb3dkSFC1soY3NMt9guwLK5Cz8=; b=Zfbxm/onGVlQYE5+1EE3WiDcmbc34j6SWZTV22BkEpFF1Hgl8QW4ApM9CMWGhaDZC3 YTtoWkLvclN9CPwhU20sWeg+jK/hYsyyI3R8gss8qgYmT6Bu9MnMD1EfhC3FATgA1le2 q9ASVgRwEXBavsBQDuOJJBiAxNrj3fKDdcrnK/A6HnjYAbgbqgcTrZoXL0CA5ALC0KEe FPiPAKY4BgsghmHKYZkv+1XRi7VdHSVE0P4UtnvA/roQCPjrVTu/92yLuRbJzsnzT3tJ zlSrYXC8M86dbmqf1iUaSnokFihbtOwC6OZG8urZQU+CF5Uy4PnP8AFDCJ8/CrMFwL4z FxEQ== X-Gm-Message-State: ALoCoQlzRyIwx9uiNRUNf4zEc7dG45gjl5VLO2WdaVBMaer1gwkI2Cx/QNmSW7zn+i5uUTu+j2LD X-Received: by 10.236.150.110 with SMTP id y74mr1370846yhj.7.1406807659723; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.107.198 with SMTP id h64ls792352qgf.66.gmail; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) X-Received: by 10.220.68.208 with SMTP id w16mr887606vci.79.1406807659608; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) Received: from mail-vc0-x230.google.com (mail-vc0-x230.google.com [2607:f8b0:400c:c03::230]) by mx.google.com with ESMTPS id li13si4101785vdb.94.2014.07.31.04.54.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Jul 2014 04:54:19 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::230 as permitted sender) client-ip=2607:f8b0:400c:c03::230; Received: by mail-vc0-f176.google.com with SMTP id id10so3947795vcb.7 for ; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) X-Received: by 10.220.118.136 with SMTP id v8mr11905645vcq.50.1406807659515; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp11913vcb; Thu, 31 Jul 2014 04:54:19 -0700 (PDT) X-Received: by 10.70.131.35 with SMTP id oj3mr11741415pdb.116.1406807658629; Thu, 31 Jul 2014 04:54:18 -0700 (PDT) Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTP id ad7si5688509pad.92.2014.07.31.04.54.18 for ; Thu, 31 Jul 2014 04:54:18 -0700 (PDT) Received-SPF: none (google.com: piglit-bounces@lists.freedesktop.org does not designate permitted sender hosts) client-ip=131.252.210.177; Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 470ED6E209; Thu, 31 Jul 2014 04:54:17 -0700 (PDT) X-Original-To: piglit@lists.freedesktop.org Delivered-To: piglit@lists.freedesktop.org Received: from nm22-vm7.bullet.mail.gq1.yahoo.com (nm22-vm7.bullet.mail.gq1.yahoo.com [98.136.217.70]) by gabe.freedesktop.org (Postfix) with ESMTP id 018496E209 for ; Thu, 31 Jul 2014 04:54:14 -0700 (PDT) Received: from [98.137.12.63] by nm22.bullet.mail.gq1.yahoo.com with NNFMP; 31 Jul 2014 11:54:13 -0000 Received: from [208.71.42.196] by tm8.bullet.mail.gq1.yahoo.com with NNFMP; 31 Jul 2014 11:54:13 -0000 Received: from [127.0.0.1] by smtp207.mail.gq1.yahoo.com with NNFMP; 31 Jul 2014 11:54:13 -0000 X-Yahoo-Newman-Id: 642031.96157.bm@smtp207.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 3_LS96sVM1kWexWKOJgJdUaHR.pSaqk.7qamNShH097pXs4 0Ulw2XzHKqCUDaHyQMRGrrgdOsVc_7FJ242Icx85hh0CoVgl2h1ldADFFByi TPcsodXHaoCOHOy3Iw5Am9ji12y8JKl3k0J5zrYF5l8WvOEEtR0nlwgvsb83 Z651MxsafEUNjN92PB8FOPIR0pdpdycKi1B6Ecv1zOlHZWhYonOOfRsPK20U lG1UAwzZ8IwzF0xfnE2PKibOSt9riT439RJwA9iEaYUwNzeELiSpJ7D09ECj 13.LPKZI18GPf_mTwt0YulHfrdh2sG7Op6yOfb8L6z7rwTvjxLtEetn6jiFG 9025zuYNbVPnckrAqeC5pbsqaRwM_QFxJX9EGz2.iypNC7AFRsoZ79j5.4e5 gcW.OYpS6.StadZHStBDT5bEm2lQduxXxUXx9mCsZJw4iw81lEsoQu6jW403 MsueNCUA8t30Goxxs8aguxZ41l702DYKIAk7ijA6s7yhPctYFhZVLYQt8yz7 L930LmPL9s.Mb546CTITq.KGKXeY2MULf3Bd7wXBmAk54VAg98Bk39MEok7_ E4Fc9tPSV X-Yahoo-SMTP: 9BNlx.aswBAkr0D8mG_whiOP1dyU From: "'Timothy Arceri' via Patchwork Forward" To: piglit@lists.freedesktop.org Date: Thu, 31 Jul 2014 21:53:40 +1000 Message-Id: <1406807620-6711-1-git-send-email-t_arceri@yahoo.com.au> X-Mailer: git-send-email 1.9.3 Subject: [Piglit] [PATCH V2] glsl-1.10: extend to test arrays of arrays X-BeenThere: piglit@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: piglit-bounces@lists.freedesktop.org Sender: "Piglit" X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::230 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=neutral (body hash did not verify) header.i=@; dmarc=fail (p=NONE dis=NONE) header.from=yahoo.com.au Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 X-Original-From: Timothy Arceri Reply-To: Timothy Arceri Extends the varying packing tests to support testing arrays of arrays V2: renamed variables from 'inner' that should have been 'outer' Signed-off-by: Timothy Arceri --- tests/all.py | 2 +- .../glsl-1.10/execution/varying-packing/simple.c | 158 ++++++++++++++------- 2 files changed, 109 insertions(+), 51 deletions(-) diff --git a/tests/all.py b/tests/all.py index 9d7a861..90e263b 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1010,7 +1010,7 @@ spec['glsl-1.10']['execution']['varying-packing'] = {} for type in ['int', 'uint', 'float', 'vec2', 'vec3', 'vec4', 'ivec2', 'ivec3', 'ivec4', 'uvec2', 'uvec3', 'uvec4', 'mat2', 'mat3', 'mat4', 'mat2x3', 'mat2x4', 'mat3x2', 'mat3x4', 'mat4x2', 'mat4x3']: - for arrayspec in ['array', 'separate']: + for arrayspec in ['array', 'separate', 'arrays_of_arrays']: cmdline = 'simple {0} {1}'.format(type, arrayspec) spec['glsl-1.10']['execution']['varying-packing'][cmdline] = \ concurrent_test('varying-packing-' + cmdline) diff --git a/tests/spec/glsl-1.10/execution/varying-packing/simple.c b/tests/spec/glsl-1.10/execution/varying-packing/simple.c index 87ff37e..9ed6e09 100644 --- a/tests/spec/glsl-1.10/execution/varying-packing/simple.c +++ b/tests/spec/glsl-1.10/execution/varying-packing/simple.c @@ -97,6 +97,8 @@ */ #include "piglit-util-gl.h" +static const int outer_dim_size = 2; + PIGLIT_GL_TEST_CONFIG_BEGIN config.supports_gl_compat_version = 10; @@ -115,6 +117,14 @@ enum base_type BASE_TYPE_INT, }; +enum test_array_type +{ + SEPARATE, + ARRAY, + ARRAYS_OF_ARRAYS, +}; + + static const char * get_base_type_name(enum base_type t) { @@ -189,7 +199,8 @@ const struct type_desc *all_types[] = { struct varying_desc { const struct type_desc *type; - unsigned array_elems; + unsigned one_dim_array_elems; + unsigned two_dim_array_elems; }; /** @@ -198,12 +209,12 @@ struct varying_desc */ static GLint get_shader(bool is_vs, unsigned glsl_version, int num_varyings, - struct varying_desc *varyings) + struct varying_desc *varyings, enum test_array_type array_type) { GLuint shader; char *full_text = malloc(1000 * 100 + num_varyings); char *text = full_text; - unsigned i, j, k, l; + unsigned i, j, k, l, m; const char *varying_keyword; unsigned offset = 0; GLenum shader_type = is_vs ? GL_VERTEX_SHADER : GL_FRAGMENT_SHADER; @@ -218,16 +229,24 @@ get_shader(bool is_vs, unsigned glsl_version, int num_varyings, } text += sprintf(text, "#version %u\n", glsl_version); + if (array_type == ARRAYS_OF_ARRAYS) + text += sprintf(text, "#extension GL_ARB_arrays_of_arrays: enable\n"); text += sprintf(text, "uniform int i;\n"); for (i = 0; i < num_varyings; ++i) { const char *opt_flat_keyword = ""; if (varyings[i].type->base != BASE_TYPE_FLOAT) opt_flat_keyword = "flat "; - if (varyings[i].array_elems != 0) { + if (varyings[i].two_dim_array_elems != 0) { + text += sprintf(text, "%s%s %s var%u[%u][%u];\n", + opt_flat_keyword, varying_keyword, + varyings[i].type->name, i, + outer_dim_size, + varyings[i].two_dim_array_elems); + } else if (varyings[i].one_dim_array_elems != 0) { text += sprintf(text, "%s%s %s var%u[%u];\n", opt_flat_keyword, varying_keyword, varyings[i].type->name, i, - varyings[i].array_elems); + varyings[i].one_dim_array_elems); } else { text += sprintf(text, "%s%s %s var%u;\n", opt_flat_keyword, varying_keyword, @@ -243,37 +262,47 @@ get_shader(bool is_vs, unsigned glsl_version, int num_varyings, else text += sprintf(text, " bool failed = false;\n"); for (i = 0; i < num_varyings; ++i) { - unsigned array_loop_bound = varyings[i].array_elems; + unsigned array_loop_bound; + unsigned outer_array_loop_bound = 1; const char *base_type_name = get_base_type_name(varyings[i].type->base); + if (varyings[i].two_dim_array_elems != 0) { + outer_array_loop_bound = outer_dim_size; + array_loop_bound = varyings[i].two_dim_array_elems; + } else + array_loop_bound = varyings[i].one_dim_array_elems; if (array_loop_bound == 0) array_loop_bound = 1; - for (j = 0; j < array_loop_bound; ++j) { - for (k = 0; k < varyings[i].type->num_cols; ++k) { - for (l = 0; l < varyings[i].type->num_rows; ++l) { - text += sprintf(text, " "); - if (!is_vs) - text += sprintf(text, "if ("); - text += sprintf(text, "var%u", i); - if (varyings[i].array_elems) - text += sprintf(text, "[%u]", j); - if (varyings[i].type->num_cols > 1) - text += sprintf(text, "[%u]", k); - if (varyings[i].type->num_rows > 1) - text += sprintf(text, "[%u]", l); - if (is_vs) - text += sprintf(text, " = "); - else - text += sprintf(text, " != "); - text += sprintf(text, "%s(i + %u)", - base_type_name, - offset++); - if (is_vs) { - text += sprintf(text, ";\n"); - } else { - text += sprintf(text, - ")\n" - " failed = true;\n"); + for (j = 0; j < outer_array_loop_bound; ++j) { + for (k = 0; k < array_loop_bound; ++k) { + for (l = 0; l < varyings[i].type->num_cols; ++l) { + for (m = 0; m < varyings[i].type->num_rows; ++m) { + text += sprintf(text, " "); + if (!is_vs) + text += sprintf(text, "if ("); + text += sprintf(text, "var%u", i); + if (varyings[i].two_dim_array_elems) + text += sprintf(text, "[%u]", j); + if (varyings[i].one_dim_array_elems || varyings[i].two_dim_array_elems) + text += sprintf(text, "[%u]", k); + if (varyings[i].type->num_cols > 1) + text += sprintf(text, "[%u]", l); + if (varyings[i].type->num_rows > 1) + text += sprintf(text, "[%u]", m); + if (is_vs) + text += sprintf(text, " = "); + else + text += sprintf(text, " != "); + text += sprintf(text, "%s(i + %u)", + base_type_name, + offset++); + if (is_vs) { + text += sprintf(text, ";\n"); + } else { + text += sprintf(text, + ")\n" + " failed = true;\n"); + } } } } @@ -302,7 +331,8 @@ get_shader(bool is_vs, unsigned glsl_version, int num_varyings, */ static unsigned choose_varyings(struct varying_desc *varyings, - const struct type_desc *test_type, GLboolean test_array, + const struct type_desc *test_type, + enum test_array_type array_type, unsigned max_varying_floats) { unsigned num_varyings = 0; @@ -310,24 +340,43 @@ choose_varyings(struct varying_desc *varyings, = test_type->num_cols * test_type->num_rows; unsigned num_test_varyings = max_varying_floats / components_in_test_type; + unsigned num_two_dim_test_varyings + = num_test_varyings / outer_dim_size; + unsigned num_extra_arrays = 0; unsigned num_extra_varyings = max_varying_floats - num_test_varyings * components_in_test_type; unsigned i; - if (test_array) { + if (array_type == ARRAYS_OF_ARRAYS) { varyings[num_varyings].type = test_type; - varyings[num_varyings].array_elems = num_test_varyings; + varyings[num_varyings].two_dim_array_elems = num_two_dim_test_varyings; + varyings[num_varyings].one_dim_array_elems = 0; + num_extra_arrays + = num_test_varyings - (num_two_dim_test_varyings * outer_dim_size); + ++num_varyings; + if (num_extra_arrays > 0) { + varyings[num_varyings].type = test_type; + varyings[num_varyings].two_dim_array_elems = 0; + varyings[num_varyings].one_dim_array_elems = num_extra_arrays; + ++num_varyings; + } + } else if (array_type == ARRAY) { + varyings[num_varyings].type = test_type; + varyings[num_varyings].two_dim_array_elems = 0; + varyings[num_varyings].one_dim_array_elems = num_test_varyings; ++num_varyings; } else { for (i = 0; i < num_test_varyings; ++i) { varyings[num_varyings].type = test_type; - varyings[num_varyings].array_elems = 0; + varyings[num_varyings].two_dim_array_elems = 0; + varyings[num_varyings].one_dim_array_elems = 0; ++num_varyings; } } for (i = 0; i < num_extra_varyings; ++i) { varyings[num_varyings].type = &float_type; - varyings[num_varyings].array_elems = 0; + varyings[num_varyings].two_dim_array_elems = 0; + varyings[num_varyings].one_dim_array_elems = 0; ++num_varyings; } @@ -344,6 +393,8 @@ print_usage_and_exit(const char *prog_name) printf(" %s\n", all_types[i]->name); printf(" and is one of:\n" " array: test using an array of the above type\n" + " arrays_of_arrays: test using a multidimensional array" + " of the above type\n" " separate: test using separately declared varyings\n"); piglit_report_result(PIGLIT_FAIL); } @@ -353,10 +404,11 @@ piglit_init(int argc, char **argv) { unsigned i; const struct type_desc *test_type; - GLboolean test_array; + enum test_array_type array_type; GLint max_varying_floats; struct varying_desc *varyings; unsigned num_varyings; + unsigned glsl_version; GLuint vs, fs; if (argc != 3) @@ -365,29 +417,35 @@ piglit_init(int argc, char **argv) if (strcmp(argv[1], all_types[i]->name) == 0) break; } - if (all_types[i]) + if (all_types[i]) { test_type = all_types[i]; - else + glsl_version = test_type->glsl_version_required; + } else print_usage_and_exit(argv[0]); if (strcmp(argv[2], "array") == 0) - test_array = GL_TRUE; + array_type = ARRAY; else if (strcmp(argv[2], "separate") == 0) - test_array = GL_FALSE; - else + array_type = SEPARATE; + else if (strcmp(argv[2], "arrays_of_arrays") == 0) { + array_type = ARRAYS_OF_ARRAYS; + piglit_require_extension("GL_ARB_arrays_of_arrays"); + if (glsl_version < 120) + glsl_version = 120; + } else print_usage_and_exit(argv[0]); piglit_require_gl_version(20); - piglit_require_GLSL_version(test_type->glsl_version_required); + piglit_require_GLSL_version(glsl_version); glGetIntegerv(GL_MAX_VARYING_FLOATS, &max_varying_floats); varyings = malloc(sizeof(*varyings) * max_varying_floats); - num_varyings = choose_varyings(varyings, test_type, - test_array, max_varying_floats); + num_varyings = choose_varyings(varyings, test_type, array_type, + max_varying_floats); - vs = get_shader(true, test_type->glsl_version_required, - num_varyings, varyings); - fs = get_shader(false, test_type->glsl_version_required, - num_varyings, varyings); + vs = get_shader(true, glsl_version, + num_varyings, varyings, array_type); + fs = get_shader(false, glsl_version, + num_varyings, varyings, array_type); prog = piglit_link_simple_program(vs, fs); i_location = glGetUniformLocation(prog, "i"); free(varyings);