From patchwork Tue Apr 30 10:48:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 793303 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:54f:b0:34d:5089:5a9e with SMTP id b15csp188534wrf; Tue, 30 Apr 2024 03:49:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWywexfKZrn7y/2W1Ue7DlkndNPfE/B8Z14BcD9Mp4R/R7HUKcDcFVq3zzwcsAgIDFGzWvVDWX8CwnOoz8vav7i X-Google-Smtp-Source: AGHT+IE8Eh3VrZiPjkBqSyTAOtCizDeWzgvKEuHYsn/UW/r3grt+azgldKn6hqIfsCAhz0oDj+NR X-Received: by 2002:ad4:5966:0:b0:6a0:582d:496e with SMTP id eq6-20020ad45966000000b006a0582d496emr17807613qvb.55.1714474160509; Tue, 30 Apr 2024 03:49:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714474160; cv=none; d=google.com; s=arc-20160816; b=Qz6UkJajfcvQn2tKcimWNtPEjJpt6ibMDYXUDkbkvg367mr8MuBC/B0Oh4et9v7Be7 SUhyZbAzbwRujiZxq40YFYctHOeTQ1x7UiLE4NaBziOAfn3VnCB4ApEy8+BHQxbHgyGf WERggz1OxBh9wgc3W6eTHcTIGsTLul9enF/EJxTetcQBwgMD2S7B0o+4ARK3mT6cgLJF 1w1ZeFPiHqZh/ZwnF8hrOLPNefY+mGV/YDhheGJ+glHeCSYeqjI83WRrtCUPSfN+AtMN dHHYwYPAp1xnwf/VmnSkanCYVpa7RMarkPUtGMmup34FDzrGFNC8LmOWEvSV9GcdtSAF Ifqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=5Wxgct4ui4g9Wvlaph5wUmRgy7/1l6XnBwBGChAdhpQ=; fh=bSRK3o/u9Y4OdPMx/Ao2bO7yAjyZthhY4bf2p4QedUE=; b=Z8oPCtO1GjncLhcmnp1RbOLrsL4k8RCUw2ql8QLY3Yo/oRo9+0nbB304RJmfAhg6Ur /boPETT7DTkrbDa+qKMLr2yBuk9GuPMLwWZdgFRR5jpSFq6Jm8/z3F8+l3Yt/yZU5n4l HoW5KmVLGMkbeJ5NPvGNFsnzy4V6mZapjIGpytCeNphVON4iFIvR26yMw4PEELmwtFuZ NbLpZ0YjPdzuN/AnHBFt/SmhVjCr468ytuBSrCNzZQM5I2hjdQ0gPAY+//zLeK772g3x CRoK4bQ0/8PJZ9OrpKQAS4w9jBBfT8xTg0dKafQs8eXjchSzz2SGxHevF9MM66B76fQa C0yA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xFJ/nKnh"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u12-20020ad45aac000000b006a0ccebd224si4879655qvg.239.2024.04.30.03.49.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2024 03:49:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xFJ/nKnh"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1l2R-0000aL-Az; Tue, 30 Apr 2024 06:48:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1l2O-0000Zl-7Y for qemu-devel@nongnu.org; Tue, 30 Apr 2024 06:48:40 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1l2M-000059-I0 for qemu-devel@nongnu.org; Tue, 30 Apr 2024 06:48:39 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-516ef30b16eso6274355e87.3 for ; Tue, 30 Apr 2024 03:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714474116; x=1715078916; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Wxgct4ui4g9Wvlaph5wUmRgy7/1l6XnBwBGChAdhpQ=; b=xFJ/nKnhk+sX2wBeZcu52nbeYbHaOnJcPSGx6ed1xCGACwf2WxB1alTGSXLCyLZSxn jLVNIGaTcKHa+ZbKRHjXpKIJngAUS1vDh5pYewP0cVN+WHWdyLwz770ujpK9bzxJEvtU uJgiE5Wc0IM07/+cce4e1lqjHAIIM7LtYpcxhE/doeN+t/W+YM05w7wsuUW2aL3KivKl nxW1qZCVcokcjyfOlQkNn/8aM/5rZZyrzrrZLE8m2+fbzQplVbYvupqppcrwQg4crAcn nk0t8pEQPo0Ys0ZmkJc9f1fW6DhQ77hHB6iKObhrLt4XOXGreYOsWoUbdpkepCOmun7S j+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714474116; x=1715078916; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5Wxgct4ui4g9Wvlaph5wUmRgy7/1l6XnBwBGChAdhpQ=; b=ZvPlD9cs74wNe7WPD7jOAVfBWEuvKX+2zdpyMgkH7sXVMQCXudf6LEKq08oF4HA78d 1XBnPNpmS4I5jQuT7THMlU6mqZv+IjaMJtQuQlCQsLW1OmL3ZwkwJRVqDXzMHrIxvXHT FLcXFNqKU+BzimUt+hyJpS3P0PdHpfPlaHk4244wVnrlXL7IjpQt1pDcz1hL/qW3VPiJ EL0/MnywfCqG3MICD/tr5f3unNdVvuUqO9XMhmirhDof1/Fi60Wa48mN/xJMxWPL4VsA p8a0XbinY3M5gh/BFS3Uws/QUSi5fERQLJJOMnmZnnewTb7ftm0Q3T4eGrOolB8u4yBg 4Xuw== X-Gm-Message-State: AOJu0YwvnCF3/3S0WK03cvE3wzPJK7n38ZDmSwa2afvOnBvx8KEZmICL +57OT3uIg6ZTLW/UoWy2fJqyd0KbMnZFTTM0yKKsB3Yq6t2PC2m9FQnudaL4FPbmWIjqqeRnudm NeVU= X-Received: by 2002:a19:7014:0:b0:51a:c207:12b with SMTP id h20-20020a197014000000b0051ac207012bmr1396473lfc.37.1714474115990; Tue, 30 Apr 2024 03:48:35 -0700 (PDT) Received: from m1x-phil.lan (mab78-h01-176-184-55-179.dsl.sta.abo.bbox.fr. [176.184.55.179]) by smtp.gmail.com with ESMTPSA id m9-20020a05600c4f4900b0041bed36e23csm11452467wmq.39.2024.04.30.03.48.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Apr 2024 03:48:35 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: John Paul Adrian Glaubitz , Yoshinori Sato , =?utf-8?q?Philippe_Mathieu-Dau?= =?utf-8?q?d=C3=A9?= , qemu-stable@nongnu.org, Paul Cercueil Subject: [PATCH] target/sh4: Fix ADDV opcode Date: Tue, 30 Apr 2024 12:48:33 +0200 Message-ID: <20240430104833.69600-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=philmd@linaro.org; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The documentation says: ADDV Rm, Rn Rn + Rm -> Rn, overflow -> T But QEMU implementation was: ADDV Rm, Rn Rn + Rm -> Rm, overflow -> T Fix by filling the correct Rm register. Cc: qemu-stable@nongnu.org Fixes: ad8d25a11f ("target-sh4: implement addv and subv using TCG") Reported-by: Paul Cercueil Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2317 Signed-off-by: Philippe Mathieu-Daudé --- target/sh4/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index ebb6c901bf..4a1dd0d1f4 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -714,7 +714,7 @@ static void _decode_opc(DisasContext * ctx) tcg_gen_xor_i32(t2, REG(B7_4), REG(B11_8)); tcg_gen_andc_i32(cpu_sr_t, t1, t2); tcg_gen_shri_i32(cpu_sr_t, cpu_sr_t, 31); - tcg_gen_mov_i32(REG(B7_4), t0); + tcg_gen_mov_i32(REG(B11_8), t0); } return; case 0x2009: /* and Rm,Rn */