mbox series

[v3,0/3] usb: add isp1760 hcd support

Message ID 20220525132251.240868-1-rui.silva@linaro.org
Headers show
Series usb: add isp1760 hcd support | expand

Message

Rui Miguel Silva May 25, 2022, 1:22 p.m. UTC
Add support for the usb isp1760 host controller family, which
for example is present in MPS3 FPGA board from Arm (isp1763).

First we move some helper functions and defines to a more
common place to be shared by several urb users. (patch 1/3)

Then add the driver itself, is a ported version of the kernel
actual driver, which I am also the maintainer. (patch 2/3)

And last, enable it for the corstone1000 platform that uses
that MPS3 board for its implementation (patch 3/3).

Cheers,
   Rui

v2[3] -> v3:
    - when you think you have amend commit and fix stay
      uncommitted.
      s/[HC_FIELD_MAX] = {};/[HC_FIELD_MAX] = {},/
v1[0] -> v2:
    - gentle ping
    - merge fix from kernel upstream [1]

PS: This should go on top of the corstone1000 platform enable
series [2]

0: https://lore.kernel.org/u-boot/20220512142016.2025129-1-rui.silva@linaro.org/
1: https://lore.kernel.org/linux-usb/20220516091424.391209-1-linus.walleij@linaro.org/
2: https://lore.kernel.org/u-boot/20220511095541.1461937-1-rui.silva@linaro.org/T/#t
3: https://lore.kernel.org/u-boot/20220523090119.1212016-1-rui.silva@linaro.org/

Rui Miguel Silva (3):
  usb: common: move urb code to common
  usb: add isp1760 family driver
  corstone1000: enable isp1763 usb controller and mmc

 Makefile                                      |    1 +
 configs/corstone1000_defconfig                |    3 +
 drivers/usb/Kconfig                           |    2 +
 drivers/usb/common/Makefile                   |    3 +
 drivers/usb/common/usb_urb.c                  |  160 ++
 drivers/usb/host/r8a66597-hcd.c               |   30 +-
 drivers/usb/isp1760/Kconfig                   |   12 +
 drivers/usb/isp1760/Makefile                  |    6 +
 drivers/usb/isp1760/isp1760-core.c            |  380 +++
 drivers/usb/isp1760/isp1760-core.h            |   96 +
 drivers/usb/isp1760/isp1760-hcd.c             | 2477 +++++++++++++++++
 drivers/usb/isp1760/isp1760-hcd.h             |   81 +
 drivers/usb/isp1760/isp1760-if.c              |  125 +
 drivers/usb/isp1760/isp1760-regs.h            |  292 ++
 drivers/usb/isp1760/isp1760-uboot.c           |   75 +
 drivers/usb/isp1760/isp1760-uboot.h           |   27 +
 drivers/usb/musb-new/musb_core.c              |    2 +-
 drivers/usb/musb-new/musb_host.c              |    2 +-
 drivers/usb/musb-new/musb_host.h              |    2 +-
 drivers/usb/musb-new/musb_uboot.c             |   38 +-
 drivers/usb/musb-new/musb_uboot.h             |    2 +-
 include/configs/corstone1000.h                |    6 +
 .../linux/usb/usb_urb_compat.h                |   47 +-
 include/usb_defs.h                            |   32 +
 24 files changed, 3825 insertions(+), 76 deletions(-)
 create mode 100644 drivers/usb/common/usb_urb.c
 create mode 100644 drivers/usb/isp1760/Kconfig
 create mode 100644 drivers/usb/isp1760/Makefile
 create mode 100644 drivers/usb/isp1760/isp1760-core.c
 create mode 100644 drivers/usb/isp1760/isp1760-core.h
 create mode 100644 drivers/usb/isp1760/isp1760-hcd.c
 create mode 100644 drivers/usb/isp1760/isp1760-hcd.h
 create mode 100644 drivers/usb/isp1760/isp1760-if.c
 create mode 100644 drivers/usb/isp1760/isp1760-regs.h
 create mode 100644 drivers/usb/isp1760/isp1760-uboot.c
 create mode 100644 drivers/usb/isp1760/isp1760-uboot.h
 rename drivers/usb/musb-new/usb-compat.h => include/linux/usb/usb_urb_compat.h (59%)

Comments

Rui Miguel Silva June 7, 2022, 8:58 a.m. UTC | #1
Hi all,
On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva wrote:
> Add support for the usb isp1760 host controller family, which
> for example is present in MPS3 FPGA board from Arm (isp1763).
> 
> First we move some helper functions and defines to a more
> common place to be shared by several urb users. (patch 1/3)
> 
> Then add the driver itself, is a ported version of the kernel
> actual driver, which I am also the maintainer. (patch 2/3)
> 
> And last, enable it for the corstone1000 platform that uses
> that MPS3 board for its implementation (patch 3/3).

Gentle ping! Am I missing someone that should be in direct CC?

Thanks in advance.
Cheers,
     Rui
> 
> Cheers,
>    Rui
> 
> v2[3] -> v3:
>     - when you think you have amend commit and fix stay
>       uncommitted.
>       s/[HC_FIELD_MAX] = {};/[HC_FIELD_MAX] = {},/
> v1[0] -> v2:
>     - gentle ping
>     - merge fix from kernel upstream [1]
> 
> PS: This should go on top of the corstone1000 platform enable
> series [2]
> 
> 0: https://lore.kernel.org/u-boot/20220512142016.2025129-1-rui.silva@linaro.org/
> 1: https://lore.kernel.org/linux-usb/20220516091424.391209-1-linus.walleij@linaro.org/
> 2: https://lore.kernel.org/u-boot/20220511095541.1461937-1-rui.silva@linaro.org/T/#t
> 3: https://lore.kernel.org/u-boot/20220523090119.1212016-1-rui.silva@linaro.org/
> 
> Rui Miguel Silva (3):
>   usb: common: move urb code to common
>   usb: add isp1760 family driver
>   corstone1000: enable isp1763 usb controller and mmc
> 
>  Makefile                                      |    1 +
>  configs/corstone1000_defconfig                |    3 +
>  drivers/usb/Kconfig                           |    2 +
>  drivers/usb/common/Makefile                   |    3 +
>  drivers/usb/common/usb_urb.c                  |  160 ++
>  drivers/usb/host/r8a66597-hcd.c               |   30 +-
>  drivers/usb/isp1760/Kconfig                   |   12 +
>  drivers/usb/isp1760/Makefile                  |    6 +
>  drivers/usb/isp1760/isp1760-core.c            |  380 +++
>  drivers/usb/isp1760/isp1760-core.h            |   96 +
>  drivers/usb/isp1760/isp1760-hcd.c             | 2477 +++++++++++++++++
>  drivers/usb/isp1760/isp1760-hcd.h             |   81 +
>  drivers/usb/isp1760/isp1760-if.c              |  125 +
>  drivers/usb/isp1760/isp1760-regs.h            |  292 ++
>  drivers/usb/isp1760/isp1760-uboot.c           |   75 +
>  drivers/usb/isp1760/isp1760-uboot.h           |   27 +
>  drivers/usb/musb-new/musb_core.c              |    2 +-
>  drivers/usb/musb-new/musb_host.c              |    2 +-
>  drivers/usb/musb-new/musb_host.h              |    2 +-
>  drivers/usb/musb-new/musb_uboot.c             |   38 +-
>  drivers/usb/musb-new/musb_uboot.h             |    2 +-
>  include/configs/corstone1000.h                |    6 +
>  .../linux/usb/usb_urb_compat.h                |   47 +-
>  include/usb_defs.h                            |   32 +
>  24 files changed, 3825 insertions(+), 76 deletions(-)
>  create mode 100644 drivers/usb/common/usb_urb.c
>  create mode 100644 drivers/usb/isp1760/Kconfig
>  create mode 100644 drivers/usb/isp1760/Makefile
>  create mode 100644 drivers/usb/isp1760/isp1760-core.c
>  create mode 100644 drivers/usb/isp1760/isp1760-core.h
>  create mode 100644 drivers/usb/isp1760/isp1760-hcd.c
>  create mode 100644 drivers/usb/isp1760/isp1760-hcd.h
>  create mode 100644 drivers/usb/isp1760/isp1760-if.c
>  create mode 100644 drivers/usb/isp1760/isp1760-regs.h
>  create mode 100644 drivers/usb/isp1760/isp1760-uboot.c
>  create mode 100644 drivers/usb/isp1760/isp1760-uboot.h
>  rename drivers/usb/musb-new/usb-compat.h => include/linux/usb/usb_urb_compat.h (59%)
> 
> -- 
> 2.36.1
>
Rui Miguel Silva June 14, 2022, 5:44 p.m. UTC | #2
Hi *,
On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva wrote:
> Add support for the usb isp1760 host controller family, which
> for example is present in MPS3 FPGA board from Arm (isp1763).
> 
> First we move some helper functions and defines to a more
> common place to be shared by several urb users. (patch 1/3)
> 
> Then add the driver itself, is a ported version of the kernel
> actual driver, which I am also the maintainer. (patch 2/3)
> 
> And last, enable it for the corstone1000 platform that uses
> that MPS3 board for its implementation (patch 3/3).
>

Any chance this series get some feedback?

Thanks in advance,

Cheers,
  Rui

> 
> Cheers,
>    Rui
> 
> v2[3] -> v3:
>     - when you think you have amend commit and fix stay
>       uncommitted.
>       s/[HC_FIELD_MAX] = {};/[HC_FIELD_MAX] = {},/
> v1[0] -> v2:
>     - gentle ping
>     - merge fix from kernel upstream [1]
> 
> PS: This should go on top of the corstone1000 platform enable
> series [2]
> 
> 0: https://lore.kernel.org/u-boot/20220512142016.2025129-1-rui.silva@linaro.org/
> 1: https://lore.kernel.org/linux-usb/20220516091424.391209-1-linus.walleij@linaro.org/
> 2: https://lore.kernel.org/u-boot/20220511095541.1461937-1-rui.silva@linaro.org/T/#t
> 3: https://lore.kernel.org/u-boot/20220523090119.1212016-1-rui.silva@linaro.org/
> 
> Rui Miguel Silva (3):
>   usb: common: move urb code to common
>   usb: add isp1760 family driver
>   corstone1000: enable isp1763 usb controller and mmc
> 
>  Makefile                                      |    1 +
>  configs/corstone1000_defconfig                |    3 +
>  drivers/usb/Kconfig                           |    2 +
>  drivers/usb/common/Makefile                   |    3 +
>  drivers/usb/common/usb_urb.c                  |  160 ++
>  drivers/usb/host/r8a66597-hcd.c               |   30 +-
>  drivers/usb/isp1760/Kconfig                   |   12 +
>  drivers/usb/isp1760/Makefile                  |    6 +
>  drivers/usb/isp1760/isp1760-core.c            |  380 +++
>  drivers/usb/isp1760/isp1760-core.h            |   96 +
>  drivers/usb/isp1760/isp1760-hcd.c             | 2477 +++++++++++++++++
>  drivers/usb/isp1760/isp1760-hcd.h             |   81 +
>  drivers/usb/isp1760/isp1760-if.c              |  125 +
>  drivers/usb/isp1760/isp1760-regs.h            |  292 ++
>  drivers/usb/isp1760/isp1760-uboot.c           |   75 +
>  drivers/usb/isp1760/isp1760-uboot.h           |   27 +
>  drivers/usb/musb-new/musb_core.c              |    2 +-
>  drivers/usb/musb-new/musb_host.c              |    2 +-
>  drivers/usb/musb-new/musb_host.h              |    2 +-
>  drivers/usb/musb-new/musb_uboot.c             |   38 +-
>  drivers/usb/musb-new/musb_uboot.h             |    2 +-
>  include/configs/corstone1000.h                |    6 +
>  .../linux/usb/usb_urb_compat.h                |   47 +-
>  include/usb_defs.h                            |   32 +
>  24 files changed, 3825 insertions(+), 76 deletions(-)
>  create mode 100644 drivers/usb/common/usb_urb.c
>  create mode 100644 drivers/usb/isp1760/Kconfig
>  create mode 100644 drivers/usb/isp1760/Makefile
>  create mode 100644 drivers/usb/isp1760/isp1760-core.c
>  create mode 100644 drivers/usb/isp1760/isp1760-core.h
>  create mode 100644 drivers/usb/isp1760/isp1760-hcd.c
>  create mode 100644 drivers/usb/isp1760/isp1760-hcd.h
>  create mode 100644 drivers/usb/isp1760/isp1760-if.c
>  create mode 100644 drivers/usb/isp1760/isp1760-regs.h
>  create mode 100644 drivers/usb/isp1760/isp1760-uboot.c
>  create mode 100644 drivers/usb/isp1760/isp1760-uboot.h
>  rename drivers/usb/musb-new/usb-compat.h => include/linux/usb/usb_urb_compat.h (59%)
> 
> -- 
> 2.36.1
>
Rui Miguel Silva June 20, 2022, 4 p.m. UTC | #3
Hi Tom,
On Tue Jun 14, 2022 at 6:45 PM WEST, Rui Miguel Silva wrote:
> Hi *,
> On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva wrote:
> > Add support for the usb isp1760 host controller family, which
> > for example is present in MPS3 FPGA board from Arm (isp1763).
> > 
> > First we move some helper functions and defines to a more
> > common place to be shared by several urb users. (patch 1/3)
> > 
> > Then add the driver itself, is a ported version of the kernel
> > actual driver, which I am also the maintainer. (patch 2/3)
> > 
> > And last, enable it for the corstone1000 platform that uses
> > that MPS3 board for its implementation (patch 3/3).
> >
>
> Any chance this series get some feedback?

Am I missing something here? to get some comments on this series?

Thanks,
Cheers,
  Rui
>
> Thanks in advance,
>
> Cheers,
>   Rui
>
> > 
> > Cheers,
> >    Rui
> > 
> > v2[3] -> v3:
> >     - when you think you have amend commit and fix stay
> >       uncommitted.
> >       s/[HC_FIELD_MAX] = {};/[HC_FIELD_MAX] = {},/
> > v1[0] -> v2:
> >     - gentle ping
> >     - merge fix from kernel upstream [1]
> > 
> > PS: This should go on top of the corstone1000 platform enable
> > series [2]
> > 
> > 0: https://lore.kernel.org/u-boot/20220512142016.2025129-1-rui.silva@linaro.org/
> > 1: https://lore.kernel.org/linux-usb/20220516091424.391209-1-linus.walleij@linaro.org/
> > 2: https://lore.kernel.org/u-boot/20220511095541.1461937-1-rui.silva@linaro.org/T/#t
> > 3: https://lore.kernel.org/u-boot/20220523090119.1212016-1-rui.silva@linaro.org/
> > 
> > Rui Miguel Silva (3):
> >   usb: common: move urb code to common
> >   usb: add isp1760 family driver
> >   corstone1000: enable isp1763 usb controller and mmc
> > 
> >  Makefile                                      |    1 +
> >  configs/corstone1000_defconfig                |    3 +
> >  drivers/usb/Kconfig                           |    2 +
> >  drivers/usb/common/Makefile                   |    3 +
> >  drivers/usb/common/usb_urb.c                  |  160 ++
> >  drivers/usb/host/r8a66597-hcd.c               |   30 +-
> >  drivers/usb/isp1760/Kconfig                   |   12 +
> >  drivers/usb/isp1760/Makefile                  |    6 +
> >  drivers/usb/isp1760/isp1760-core.c            |  380 +++
> >  drivers/usb/isp1760/isp1760-core.h            |   96 +
> >  drivers/usb/isp1760/isp1760-hcd.c             | 2477 +++++++++++++++++
> >  drivers/usb/isp1760/isp1760-hcd.h             |   81 +
> >  drivers/usb/isp1760/isp1760-if.c              |  125 +
> >  drivers/usb/isp1760/isp1760-regs.h            |  292 ++
> >  drivers/usb/isp1760/isp1760-uboot.c           |   75 +
> >  drivers/usb/isp1760/isp1760-uboot.h           |   27 +
> >  drivers/usb/musb-new/musb_core.c              |    2 +-
> >  drivers/usb/musb-new/musb_host.c              |    2 +-
> >  drivers/usb/musb-new/musb_host.h              |    2 +-
> >  drivers/usb/musb-new/musb_uboot.c             |   38 +-
> >  drivers/usb/musb-new/musb_uboot.h             |    2 +-
> >  include/configs/corstone1000.h                |    6 +
> >  .../linux/usb/usb_urb_compat.h                |   47 +-
> >  include/usb_defs.h                            |   32 +
> >  24 files changed, 3825 insertions(+), 76 deletions(-)
> >  create mode 100644 drivers/usb/common/usb_urb.c
> >  create mode 100644 drivers/usb/isp1760/Kconfig
> >  create mode 100644 drivers/usb/isp1760/Makefile
> >  create mode 100644 drivers/usb/isp1760/isp1760-core.c
> >  create mode 100644 drivers/usb/isp1760/isp1760-core.h
> >  create mode 100644 drivers/usb/isp1760/isp1760-hcd.c
> >  create mode 100644 drivers/usb/isp1760/isp1760-hcd.h
> >  create mode 100644 drivers/usb/isp1760/isp1760-if.c
> >  create mode 100644 drivers/usb/isp1760/isp1760-regs.h
> >  create mode 100644 drivers/usb/isp1760/isp1760-uboot.c
> >  create mode 100644 drivers/usb/isp1760/isp1760-uboot.h
> >  rename drivers/usb/musb-new/usb-compat.h => include/linux/usb/usb_urb_compat.h (59%)
> > 
> > -- 
> > 2.36.1
> >
Tom Rini June 20, 2022, 5:44 p.m. UTC | #4
On Mon, Jun 20, 2022 at 05:00:56PM +0100, Rui Miguel Silva wrote:
> Hi Tom,
> On Tue Jun 14, 2022 at 6:45 PM WEST, Rui Miguel Silva wrote:
> > Hi *,
> > On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva wrote:
> > > Add support for the usb isp1760 host controller family, which
> > > for example is present in MPS3 FPGA board from Arm (isp1763).
> > > 
> > > First we move some helper functions and defines to a more
> > > common place to be shared by several urb users. (patch 1/3)
> > > 
> > > Then add the driver itself, is a ported version of the kernel
> > > actual driver, which I am also the maintainer. (patch 2/3)
> > > 
> > > And last, enable it for the corstone1000 platform that uses
> > > that MPS3 board for its implementation (patch 3/3).
> > >
> >
> > Any chance this series get some feedback?
> 
> Am I missing something here? to get some comments on this series?

Marex?  Thanks.
Rui Miguel Silva June 28, 2022, 2:59 p.m. UTC | #5
Hi,
On Mon, Jun 20, 2022 at 01:44:02PM -0400, Tom Rini wrote:
> On Mon, Jun 20, 2022 at 05:00:56PM +0100, Rui Miguel Silva wrote:
> > Hi Tom, On Tue Jun 14, 2022 at 6:45 PM WEST, Rui Miguel Silva
> > wrote:
> > > Hi *, On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva
> > > wrote:
> > > > Add support for the usb isp1760 host controller family, which
> > > > for example is present in MPS3 FPGA board from Arm (isp1763).
> > > > 
> > > > First we move some helper functions and defines to a more
> > > > common place to be shared by several urb users. (patch 1/3)
> > > > 
> > > > Then add the driver itself, is a ported version of the kernel
> > > > actual driver, which I am also the maintainer. (patch 2/3)
> > > > 
> > > > And last, enable it for the corstone1000 platform that uses
> > > > that MPS3 board for its implementation (patch 3/3).
> > > >
> > >
> > > Any chance this series get some feedback?
> > 
> > Am I missing something here? to get some comments on this series?
> 
> Marex?  Thanks.

Oh well, the weekly ping. Any comments on this series?

Cheers, Rui

> 
> -- Tom
Marek Vasut June 28, 2022, 3:44 p.m. UTC | #6
On 6/28/22 16:59, Rui Miguel Silva wrote:
> Hi,
> On Mon, Jun 20, 2022 at 01:44:02PM -0400, Tom Rini wrote:
>> On Mon, Jun 20, 2022 at 05:00:56PM +0100, Rui Miguel Silva wrote:
>>> Hi Tom, On Tue Jun 14, 2022 at 6:45 PM WEST, Rui Miguel Silva
>>> wrote:
>>>> Hi *, On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva
>>>> wrote:
>>>>> Add support for the usb isp1760 host controller family, which
>>>>> for example is present in MPS3 FPGA board from Arm (isp1763).
>>>>>
>>>>> First we move some helper functions and defines to a more
>>>>> common place to be shared by several urb users. (patch 1/3)
>>>>>
>>>>> Then add the driver itself, is a ported version of the kernel
>>>>> actual driver, which I am also the maintainer. (patch 2/3)
>>>>>
>>>>> And last, enable it for the corstone1000 platform that uses
>>>>> that MPS3 board for its implementation (patch 3/3).
>>>>>
>>>>
>>>> Any chance this series get some feedback?
>>>
>>> Am I missing something here? to get some comments on this series?
>>
>> Marex?  Thanks.
> 
> Oh well, the weekly ping. Any comments on this series?

Can you rebase/resend and please CC me on the entire series ?

Thanks
Rui Miguel Silva June 28, 2022, 5:39 p.m. UTC | #7
Hi Marek,
On Tue, Jun 28, 2022 at 05:44:47PM +0200, Marek Vasut wrote:
> On 6/28/22 16:59, Rui Miguel Silva wrote:
> > Hi,
> > On Mon, Jun 20, 2022 at 01:44:02PM -0400, Tom Rini wrote:
> > > On Mon, Jun 20, 2022 at 05:00:56PM +0100, Rui Miguel Silva wrote:
> > > > Hi Tom, On Tue Jun 14, 2022 at 6:45 PM WEST, Rui Miguel Silva
> > > > wrote:
> > > > > Hi *, On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva
> > > > > wrote:
> > > > > > Add support for the usb isp1760 host controller family, which
> > > > > > for example is present in MPS3 FPGA board from Arm (isp1763).
> > > > > > 
> > > > > > First we move some helper functions and defines to a more
> > > > > > common place to be shared by several urb users. (patch 1/3)
> > > > > > 
> > > > > > Then add the driver itself, is a ported version of the kernel
> > > > > > actual driver, which I am also the maintainer. (patch 2/3)
> > > > > > 
> > > > > > And last, enable it for the corstone1000 platform that uses
> > > > > > that MPS3 board for its implementation (patch 3/3).
> > > > > > 
> > > > > 
> > > > > Any chance this series get some feedback?
> > > > 
> > > > Am I missing something here? to get some comments on this series?
> > > 
> > > Marex?  Thanks.
> > 
> > Oh well, the weekly ping. Any comments on this series?
> 
> Can you rebase/resend and please CC me on the entire series ?

Sure, will do it.

Cheers,
   Rui
> 
> Thanks