From patchwork Thu Aug 10 18:08:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 712367 Delivered-To: patch@linaro.org Received: by 2002:a05:6359:baf:b0:129:c516:61db with SMTP id gf47csp810441rwb; Thu, 10 Aug 2023 11:09:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9Kdo7gYMU6wBrHlSeJbOif2XnwczCvwY/+xz6AbNoX0tsUKEZcWoRBRzMhjESgF9RxVID X-Received: by 2002:ac2:4884:0:b0:4f5:1418:e230 with SMTP id x4-20020ac24884000000b004f51418e230mr2603283lfc.52.1691690958642; Thu, 10 Aug 2023 11:09:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691690958; cv=none; d=google.com; s=arc-20160816; b=sRXYgahKp8Lo8gWvmNXo1EA1NnDzihFX2XfGlyJPAYqm5hCoE3kF0aHktfp4L2hf4S QiP2TTHSHrfC3ddnBeP9z296cerTCifdNvST50CKzc9PqZZZzRzPxcIUxGQn+gZIlpmv 0UnSTZjfPF7/bnssqGZVoyH9ritPiE7SKKnO/ACesLA/X2vHUguY036P9S5cBzYkj61B SptOeZvbUP5TQtezOo6uMs9kKrA6C89KRPjdNjQeqLVTtO6XLnOYGUEAPXdbPJnYaQFv cA7ZU6L1kXiQ968I2ElphlsReabD11nRqHyQjeTxKk5o8NQTTRHzKFtjYWEEmuvMuRWc uOQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=iU+C7JV6FbRgzBVC3R2lwvlAYCK7PTnMEPRpbCh3lQ4=; fh=/b19ftHQMHIXIbCbVJQSxpT7BArKw1hUE4gADNgOn4s=; b=er6nd1bjH/1q0M05qcquwRfkod3pszJzdgth0zf+9jyaOBP1bhG7fVsjCQVKdwDe+z ejlyKDXavg1WSbSe29X2RUA+uoJtlMBFU2CFirETPPg12iHjMCALwaUzl72M8fuRIWy8 ewHL0Ak7SjHz7FOyi2kQZZzglPcNqNsH8x4Gjj3WJFMn2LSlZk4U4hvGh6GVraImlY2d WHW4BE1J3sBs6YWDDi4NkPuolxXS4PCHPH1wkz97bRjNz6WsD9xLhOzRrUFbbNIeY57X cqxoCVOc1X+uLfis988MGAzMy4YNv+tCmJFYkPp/hPTOFQ1TllZYEZD1O50kOmizW/WJ M6ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DrQimiDV; spf=pass (google.com: domain of gdb-patches-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gdb-patches-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Return-Path: Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id d9-20020a056402516900b005236438a658si1870032ede.612.2023.08.10.11.09.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 11:09:18 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DrQimiDV; spf=pass (google.com: domain of gdb-patches-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gdb-patches-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 803493858D32 for ; Thu, 10 Aug 2023 18:09:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 803493858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691690957; bh=iU+C7JV6FbRgzBVC3R2lwvlAYCK7PTnMEPRpbCh3lQ4=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DrQimiDVOjF+7yia085BhgDqGjnYWsAFFR2/yx8/lRVlm+xlA9gdD1HXRolIKF4Mz N3uEv76Ki8aKfkUFaDb/YWs7vTSIjBEnpg+2Ut5gJ8ogpkrkGWTEgb/YC9TNlofgU3 hoHpBzuy+8DGtCyNCHorTyG/JqBhAv6wr3FCwEoQ= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 765CF3858D32 for ; Thu, 10 Aug 2023 18:08:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 765CF3858D32 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1b9c5e07c1bso10702995ad.2 for ; Thu, 10 Aug 2023 11:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691690938; x=1692295738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iU+C7JV6FbRgzBVC3R2lwvlAYCK7PTnMEPRpbCh3lQ4=; b=QU4oGuDH9hUSxoFzI/Yw2pvrcaLC2jBLFyLy1lU2Talt13pdhqmUc92itElLJVEfpv K5NtrMjM/85Vun3alHYuiNzjJS3xSAIH1HpN8EbrHzYtAfkcopZGVyitahDA1PrPvLr6 uHwQaDsdSu5JWHIe+zqcdxHEjh4vgroIxkDUqVJu23oP1G3DxHOX5uqtqer55IpPNACy 7op6Lzmm7T10uj4wDT7lbZ0rGBnUlyhN/H9PABDivU2Ml1vEsQrjSO64ZkpDY6shJSdF zuvSrAHvWHMsc8za6Sdd2tP6d7lhhIwRCg9OYme8kyjFCT3+pQ33s2E8A/FnrWD5arYo oPzw== X-Gm-Message-State: AOJu0Yz89KhXBT4LAxOq8TDTzPcX4l1bCYxcQX5fGcUN00b9QzF2IUDN LcHAHtFEELJ6aWYHQNiZl33+0g== X-Received: by 2002:a17:902:e741:b0:1bb:8e13:deba with SMTP id p1-20020a170902e74100b001bb8e13debamr3233468plf.11.1691690938381; Thu, 10 Aug 2023 11:08:58 -0700 (PDT) Received: from stoup.. ([2602:47:d483:7301:9e4d:b830:d4fd:9164]) by smtp.gmail.com with ESMTPSA id b14-20020a170902b60e00b001bd41b70b65sm2085212pls.49.2023.08.10.11.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 11:08:57 -0700 (PDT) To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , gdb-patches@sourceware.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 4/4] gdbstub: don't complain about preemptive ACK chars Date: Thu, 10 Aug 2023 11:08:52 -0700 Message-Id: <20230810180852.54477-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230810180852.54477-1-richard.henderson@linaro.org> References: <20230810180852.54477-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Henderson via Gdb-patches From: Richard Henderson Reply-To: Richard Henderson Errors-To: gdb-patches-bounces+patch=linaro.org@sourceware.org Sender: "Gdb-patches" From: Alex Bennée When starting a remote connection GDB sends an '+': /* Ack any packet which the remote side has already sent. */ remote_serial_write ("+", 1); which gets flagged as a garbage character in the gdbstub state machine. As gdb does send it out lets be permissive about the handling so we can better see real issues. Signed-off-by: Alex Bennée Cc: gdb-patches@sourceware.org Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230810153640.1879717-9-alex.bennee@linaro.org> Signed-off-by: Richard Henderson --- gdbstub/gdbstub.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 20b6fe03fb..5f28d5cf57 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -2074,6 +2074,11 @@ void gdb_read_byte(uint8_t ch) gdbserver_state.line_buf_index = 0; gdbserver_state.line_sum = 0; gdbserver_state.state = RS_GETLINE; + } else if (ch == '+') { + /* + * do nothing, gdb may preemptively send out ACKs on + * initial connection + */ } else { trace_gdbstub_err_garbage(ch); }