From patchwork Thu Aug 24 07:36:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 716498 Delivered-To: patches@linaro.org Received: by 2002:adf:f747:0:b0:317:ecd7:513f with SMTP id z7csp1199658wrp; Thu, 24 Aug 2023 00:38:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQ0btsXpfyAyug0LKKf1jCT850XHNc96hHEdBPBx7uAdYo8h1tKSXfbs0jAkA2LjYrcDzw X-Received: by 2002:a0c:e0c2:0:b0:64f:4d37:4867 with SMTP id x2-20020a0ce0c2000000b0064f4d374867mr6617712qvk.40.1692862684271; Thu, 24 Aug 2023 00:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692862684; cv=none; d=google.com; s=arc-20160816; b=Kp7pgA4g8WZHjzR9KnSYT4gmL52/Cd9A3mK5DQED8JnrnGU6cfzuopEJsIQ0PGK4ft Q2J7A68T+EE7nLccq36piQZsYBxw/iJQZ2Ny35khNg5b04+0xiHnqG4d/oXlq0aPYBBM 6qjBO+T53knsNBb6ZJdtPxzWwatKix5NtIhoKJlEGY2IrZGGLpMNXy6fmzoYOZtd8pm9 26Nr4AjwqEtpZ2QlUcI9mkI6d5LxGIwfH2qwfj6z77BF+HHwCGInKclG42cjXTdvCXxJ 9+0o9qwdRcafBiexH8OFch9Vg1BaKz7P52y00RvGgMS4AbUVdAGyKPzRcTf25v9lSPl5 rXJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Ie5/eypvDgSiir6JOHY1F3yq0l6fHZ4sYPTnuVf9SbI=; fh=knIGEsR1Q9Shvl4iBKePZ/Zyonp3Mix1A78u/kZdKtQ=; b=tAUc+irGhQ9ul32n70oshoz9SUqU7j6WXJk+6ygP9RI3IQk6J9xzOGc/x2jAW10pfA XcliqimNm1o2RKFnxaontp52JorT//1pVAeBuX95w9GW+0gdnpZSMdu/EJIa1AikzFpo 8z1dLM6ShOPEuqy2ebRCKOd3h9c1Z5IxT7euOcfrDjl+y3/YIch3lKCnctrKny+JaH+T gZTR8/iJYhlDTFx/zZXeknaUF4FiS+LTQdzULszFsAdgk70odMm494cKJZRp8rr67R+r kVMw7atO+dR/+091q4MiHpEyjQGz3t08ScbCpdRb+kIU9PEVXHPYyVEOYV05TndY0pDF X9pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=gQOOTQq4; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id x13-20020a0c8e8d000000b0063cd7353f78si8086006qvb.253.2023.08.24.00.38.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 00:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=gQOOTQq4; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E36753F672 for ; Thu, 24 Aug 2023 07:38:03 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id 0AF343F672 for ; Thu, 24 Aug 2023 07:37:49 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gQOOTQq4; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3EA365A43; Thu, 24 Aug 2023 07:37:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 255C8C433CB; Thu, 24 Aug 2023 07:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692862668; bh=IT6/DarMvmMgdLtxu3NMd59P2v8//LyIHppUeTYy7M0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gQOOTQq40SZxFdCDuPINT253cTqh+jYadnV4m+daQzfRci08lhPVD8EBKeBYgHHON dk+L+cbR9JXP7MYaIVXnjW+CPBzVy3SxSO44a69XY+zpWlttfVKe52meQMWvfV5Kwc f1fOfAh3hPBZPdd0aTGNEVzgFzK6CqG4nsHDHvbbfBpdMKTRu4sHCsLIJNZqHvfAwc 98DEOQ/Cth0Dw7iDGnagjYLWHHUL+xod0710oP/AJK5nTHQdDFkj6oKXnr1NPbmlJG E3p5p9ysO1RW4pU/cBpPBftTo1VVQ3SrzXlFuagdims9uLEuzey2XR1/ziD2QXGElY 31VS+AIue8RYw== From: Lee Jones To: lee@kernel.org Date: Thu, 24 Aug 2023 08:36:53 +0100 Message-ID: <20230824073710.2677348-9-lee@kernel.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824073710.2677348-1-lee@kernel.org> References: <20230824073710.2677348-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 0AF343F672 X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.00 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,lists.linaro.org,amd.com,gmail.com,ffwll.ch,linaro.org,lists.freedesktop.org]; NEURAL_HAM(-0.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org Message-ID-Hash: F6IUKNTWXIRO2R2Z5HWFXPZ32GV6J2CL X-Message-ID-Hash: F6IUKNTWXIRO2R2Z5HWFXPZ32GV6J2CL X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Daniel Vetter , Sumit Semwal , Stanley Yang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush' Cc: linaro-mm-sig@lists.linaro.org --- Signed-off-by: Lee Jones Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Stanley Yang Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index 45be0af2570b2..0e25b6fb13404 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c @@ -234,7 +234,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) amdgpu_ring_write(ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer @@ -937,7 +937,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring) return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information @@ -1119,7 +1119,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count - 1; /* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @ring: amdgpu ring pointer @@ -1168,7 +1168,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer From patchwork Thu Aug 24 07:36:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 716499 Delivered-To: patches@linaro.org Received: by 2002:adf:f747:0:b0:317:ecd7:513f with SMTP id z7csp1199770wrp; Thu, 24 Aug 2023 00:38:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCaQ8RmpTEC/PUaZUWknEMXbgnLcMQ6Kcr7EXfaTTCgFn8SV2VjBxVjV+hSYHXqEaKUyLJ X-Received: by 2002:a05:622a:1492:b0:410:a018:c7f3 with SMTP id t18-20020a05622a149200b00410a018c7f3mr11855715qtx.9.1692862703207; Thu, 24 Aug 2023 00:38:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692862703; cv=none; d=google.com; s=arc-20160816; b=BR51sVHyT8xj3SmzfGrG6QgDqamxnvisfIx3ts+0pCN/8ZfBehgGTm9h/tdcRMAJY6 JilRJYx9ZbOxEtKdPEaKVabbRxr5FswrAoiHGEoJDn0/5aXzAVwJqjkPkG+qzqebzFC4 YGZ2bUEqKucsDQMQmkl6jI0bqGIIKAq2hE0AnYPX+t4WGsZF1BUSzDrKuvzIKOC1IfjV /WKCtij5LBPfXMPsGfWI/11IOHvVnJSn8sHrJ7IL6MO1xVwCV2QPMUJz1/BgJyGMGZxE 6fYCfD5PT3vyYFT3yFgjXfWTjXPaJDoGGHE+0fOW+WxuNZjdRdPLm2Bv5OktWK+x3JWl CvYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=GvBt0WzoJ1dXpb8wTK+XxI702y/c3aMTDfLUFTBhe2Y=; fh=qxmSNqyVj60qsZn67wdEbsny+IsyIol7ruv9bvLrFAI=; b=CdYmrUEBtbCReC1JhGM4AD5p0XxxlbHS8+ZeabI/vp5h8T4g5LWJHXd3S27VZH2Woq ZJBep4Q9SfilnwOALQCG36k5nfGpkfoMGQxYYLSWMauWyEhAOaN6afll+GgXlJnnEatZ 69VUd+zSFTccSUaPPxNxP4QZDSMFG2ftlLUkepiojbYuO8ffKlXKKpJvhejmLEXO6rZ5 VUnHzDP0/pdF8PpSqQtfDGqh+P11R5oflz2bFef8Jw8h90WZLtm+fTSecON00FkujZ3f GVvdHUfrApSZptmbcrFApCtx9aVDyFAvb52Yho+U6qkMEzkjF2kCwzjRkaYzQpm9uLOG /jzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=JmDzg8On; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id s1-20020ac85cc1000000b0040341331fe9si877334qta.205.2023.08.24.00.38.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 00:38:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=JmDzg8On; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id CD3353F637 for ; Thu, 24 Aug 2023 07:38:22 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id C066843C9F for ; Thu, 24 Aug 2023 07:37:54 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JmDzg8On; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A1A465936; Thu, 24 Aug 2023 07:37:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 450BDC433CB; Thu, 24 Aug 2023 07:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692862673; bh=U79uOFgK1bj6OBPdyCVW/Y7lNsxketkReBm6q4ZUwCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmDzg8On00UB4Q0g8nYLzgcTFG+0jmSIk+AItEutJcS9zfCGrEHl1Egwwtk45sm9M 08caRBSAaufQjsHXGJHS+LhNj+FeSpaLQgv9Ao7eXBheuBy+xTaj3y+06wYxXZReuZ RECrvC6TsMRAAmVfagdJ6HwxZCVdar/o/7wIsnNthArxO2rtzuyqzid4ek8egFK37e UQDPau2EcOY1cUPyLjDtYIldPt00bOhbTTOImRCXsS+6eIncUkQsZmE0/M3+/8WGF7 k0mTLR+G8d1WWAUOTuM25MeyjBo/tJPNqiYwa8T2gKV01GP9Ob1gKAW6rt66lLxnrH 4zs/NXCLrYa4Q== From: Lee Jones To: lee@kernel.org Date: Thu, 24 Aug 2023 08:36:55 +0100 Message-ID: <20230824073710.2677348-11-lee@kernel.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824073710.2677348-1-lee@kernel.org> References: <20230824073710.2677348-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: C066843C9F X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.00 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[10]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,amd.com,gmail.com,ffwll.ch,linaro.org,lists.freedesktop.org,lists.linaro.org]; NEURAL_HAM(-0.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org Message-ID-Hash: F3HO7VD37IT4JXWRTKCXTSSNBS7ICG3D X-Message-ID-Hash: F3HO7VD37IT4JXWRTKCXTSSNBS7ICG3D X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Luben Tuikov , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result' List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' Signed-off-by: Lee Jones --- Cc: Luben Tuikov Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 506371c427451..1ef558cda60ce 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq) /** * drm_sched_job_done - complete a job * @s_job: pointer to the job which is done + * @result: fence error to forward and set * * Finish the job's fence and wake up the worker thread. */ From patchwork Thu Aug 24 07:36:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 716500 Delivered-To: patches@linaro.org Received: by 2002:adf:f747:0:b0:317:ecd7:513f with SMTP id z7csp1199858wrp; Thu, 24 Aug 2023 00:38:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEL0P76qeO5koAL/PEp5vlfzvhHOs7wTIsvKe8vKQy1VhrprwZ4Xnx0uJvvnXLK3aLVuMVd X-Received: by 2002:a0c:ab5d:0:b0:64f:42eb:92ea with SMTP id i29-20020a0cab5d000000b0064f42eb92eamr10091992qvb.4.1692862722170; Thu, 24 Aug 2023 00:38:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692862722; cv=none; d=google.com; s=arc-20160816; b=LIcnbVQ8o5t05e/4RXdEWlYJQUmb3ZAzBsvRFesffqVBLX7WnuhQpiP4uFw41X2Qg+ mkzODCl1oOzdA+t5MYxeDdBt/KY0T6t301Nszzai5sHtz4uz784KqPVFzFWRxkguSQ4t +xwe4uiKKBHDsCBKWpDdCvdLEAetDbVF9Vd7RFaQwgZyGzXdbJfo0gpuIT+/OpCTldIx GGHV0q/yRSXWLJkOOC52N3eYYvYMsq7gvFy6x4Rf4aF6aERsYS8EK0kvqP4JeqHWv2eF KI3eo8JUZbb2d5pWInWqcwMuSp1vV4aUfR9cjGx/kAcrrXh30KEtm3TS3KQyW5NLQcvc KT0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=SepeaQyN8kMmNXhH/w9e1h+PFT/bEVUrZk+JMwh5VRw=; fh=m1jsJreXdI2IS+junPaYR5J4wJeGcE3JlWikcuAz+jI=; b=rD0anQ/qy1jrenIPYMVv0v79vMjZydubd5yoHSxy4/lUOheXAadyThKINtpajokgOJ w5qjH6bLMdwf9EAC2bohhP9XA/WRKvuI+gtrWswZfXpgNfsMTL7qM2YDJTenALjqizo0 Ph+6f0Axu8/SjvEVIC7vcs0pUILcMJNy0Sat8jWZWQLhrK7YlSM19umrmKmXqCEmm5r1 +xOVZzfCKZqP5K0MFt5hY0MkGgfr5SjRvO4HKdMxhtRm/3RL0lDsLtsNpUIvCDnFCLDS e7U12vFoFIDTVbxW9N0KRhXOw4+Iico4m9cI3fPkenJ0Hg8vWfxY9PXdTv78ZfGYTD6T nVWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=fIKJHkj2; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id p20-20020a0ccb94000000b0064f3cada05csi3230979qvk.159.2023.08.24.00.38.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 00:38:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=fIKJHkj2; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id BF5BF3F637 for ; Thu, 24 Aug 2023 07:38:41 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id 89E2143BBE for ; Thu, 24 Aug 2023 07:38:01 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fIKJHkj2; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33C3A65A43; Thu, 24 Aug 2023 07:38:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39DC7C433CA; Thu, 24 Aug 2023 07:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692862680; bh=wEDqvEDOA3vxGIk6EexeUNwMrFtaZlnfxVGm/bMEvr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fIKJHkj2WVKxeDY/g/PYgsJrPDBu4r0Q2mLQv1WsRpbImdKaDv6Sfi5UmzJHGHlZP /EzC9AQIvwtXl4YkhKBHfnpES4Kp8p0iTysNLX9AZzq9SmHEL4qzBlc/UUDiIZmAoO WjYmTlFojar9djx8fDMorymgkC55/WK22bS4j4KI6Q+CO7XDQuWtDYlT9f/Nr2wf96 7Mr2FJAUzQfB3jXamFypkoSKtt0meqhPSRXnRXM4yp9OFzESP3XmU5gNnoJF3G3mt2 4UY0GjWBH/koZ4QBgtg/CXHBCwTnJV3cKnMFbNPFwSUldIyq21t5k6dMjg1ZJQZmkQ XslXiYwP5lzgQ== From: Lee Jones To: lee@kernel.org Date: Thu, 24 Aug 2023 08:36:57 +0100 Message-ID: <20230824073710.2677348-13-lee@kernel.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824073710.2677348-1-lee@kernel.org> References: <20230824073710.2677348-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 89E2143BBE X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.00 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,amd.com,gmail.com,ffwll.ch,linaro.org,lists.freedesktop.org,lists.linaro.org]; NEURAL_HAM(-0.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org Message-ID-Hash: 5GHNQC5GY2EOHT5RMUKH53HDLCKX4LKD X-Message-ID-Hash: 5GHNQC5GY2EOHT5RMUKH53HDLCKX4LKD X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Daniel Vetter , Sumit Semwal , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id' List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc' Signed-off-by: Lee Jones --- Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index e77f048c99d85..d4f0e4327dd3f 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev, * @adev: amdgpu_device pointer * @reg: mmio/rlc register * @v: value to write + * @xcc_id: xcc accelerated compute core id * * this function is invoked only for the debugfs register access */ From patchwork Thu Aug 24 07:37:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 716501 Delivered-To: patches@linaro.org Received: by 2002:adf:f747:0:b0:317:ecd7:513f with SMTP id z7csp1199976wrp; Thu, 24 Aug 2023 00:39:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJRGWromi8KKVLqlEGucm2oe02HFOB1uw0w0dN3Cv+qvwzY+acwfqksf0Es3ojqKq7F57g X-Received: by 2002:a05:622a:15c9:b0:3fd:ed14:6eb9 with SMTP id d9-20020a05622a15c900b003fded146eb9mr18659955qty.11.1692862741133; Thu, 24 Aug 2023 00:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692862741; cv=none; d=google.com; s=arc-20160816; b=TOLvPPehO4zPI6Brl/QeR7xhc46JrLm+Z+R3/OOwcIb+S+LAeTNM+JjfTPOzcbUax+ jtMMHjwKngQLuGAO6l30FnoT7hsiJPp471g0xuDUEkEz8mn/MyQyh1194C7PBRV9Y/4c 35nFYyFYJBWP4y8Cm0l6KK9ZRw1yVc7sxlQkyLql5RSbjRoPyNx9ixBLMlBoyFKhTXh/ D0CjyrjxI2NRwVGuIzBLgz2F+u2ZUpj1xX7nLC4Fj8PTBrWtx+qeCfaNAYh3BLIpgQD+ YGWj/ZEf+3BaJ/1ZOBnk/PVwCPQCLq6bpS257JwhFUqjzHaL77yJ8HNtf4arBqIIVL5D mTOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=yhAs5f1e9SslImYiV3E7XzD2hCSSOtp4h0+a9XMMb0w=; fh=PZhnOf25r3rAzb7WoIqSN2STzNLXg7dby3cHV/r3k4c=; b=DbQdGqzbrMKX5LY6UtY2V0pnL3wJARxj6gRLx7dQZwWI8aOBCIK3BtU93YXkPPayx3 gAdKqiM71BsNIOv6029Scg90L/rxssobmRP57FYa+y8BsRoshMn3xvawBYEDBxVNZsi1 ax8iZnOrs230W2whBr6M4PTpWxYCbthGlu9XwyvvUN1NBc+SwHP67ItnkZCUNs8dZKrR 75PbpoCjlDk4FwBdfBKTSkFe9RCN5JFEF0fzTcxzlzeJ87Tr0Yenq+60lAHueMe5JlKe cAbCuxejBYNNgn2AmvGSW2MJxTnuPtRiR5aNoIdPH26CJm2pn2iB9rnIHUR4eNLVtoaG +l5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=JvZadWCE; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id x15-20020a05622a000f00b0040fdea287c0si3217304qtw.476.2023.08.24.00.39.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 00:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=JvZadWCE; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id B8F5A3F637 for ; Thu, 24 Aug 2023 07:39:00 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id 776AE3F672 for ; Thu, 24 Aug 2023 07:38:19 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JvZadWCE; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2276A65AF5; Thu, 24 Aug 2023 07:38:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69CD6C433CA; Thu, 24 Aug 2023 07:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692862698; bh=qTc11hboeB2aZlOqkN91NN/Dw5CZWbyrOr80wSzYNm4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JvZadWCEBYotqkspkGwfoN/lfsikJ/T6fYB+lxsBQ4+b/7xuDAS+euYAqFWJjjorV nJaf7bDOyNhZLRm3jEvgi+JdXdxxzS9roTINN1HfZo41vRV8EC4z/4GLmh1r3q/RAT gwV4hMG5CwA6dEYGxHZe7CV7AYsnuIf7L1K2fVUfHwsFcPxScxjf8LE9ya9ZtVuewB 7I8t1tgs8gXolFV3dApvgXNSvl5c9lqSMMkqraj0/2d3Werd/kFOz6G6cKvASlNYXe uJw42JOzUyihKE3BMX638v9Uw9GDCzksJVdFaGOIElhLbpHTxhaocarxF+4KPLuNti pOPqUkbedTifg== From: Lee Jones To: lee@kernel.org Date: Thu, 24 Aug 2023 08:37:03 +0100 Message-ID: <20230824073710.2677348-19-lee@kernel.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824073710.2677348-1-lee@kernel.org> References: <20230824073710.2677348-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 776AE3F672 X-Spamd-Bar: ------- X-Spamd-Result: default: False [-7.00 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,kernel.org,suse.de,gmail.com,ffwll.ch,linaro.org,amd.com,redhat.com,lists.freedesktop.org,lists.linaro.org]; NEURAL_HAM(-0.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org Message-ID-Hash: 2TIMK5KNJAX5SIHOSXPGCBK3TUBKUFOC X-Message-ID-Hash: 2TIMK5KNJAX5SIHOSXPGCBK3TUBKUFOC X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Danilo Krummrich , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev' List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’: drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] Signed-off-by: Lee Jones --- Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Danilo Krummrich Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org --- drivers/gpu/drm/drm_gpuva_mgr.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_gpuva_mgr.c index f86bfad74ff8a..ad99c9cfedac7 100644 --- a/drivers/gpu/drm/drm_gpuva_mgr.c +++ b/drivers/gpu/drm/drm_gpuva_mgr.c @@ -1076,7 +1076,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, u64 req_addr, u64 req_range, struct drm_gem_object *req_obj, u64 req_offset) { - struct drm_gpuva *va, *next, *prev = NULL; + struct drm_gpuva *va, *next; u64 req_end = req_addr + req_range; int ret; @@ -1106,7 +1106,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, ret = op_unmap_cb(ops, priv, va, merge); if (ret) return ret; - goto next; + continue; } if (end > req_end) { @@ -1151,7 +1151,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, ret = op_remap_cb(ops, priv, &p, NULL, &u); if (ret) return ret; - goto next; + continue; } if (end > req_end) { @@ -1184,7 +1184,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, ret = op_unmap_cb(ops, priv, va, merge); if (ret) return ret; - goto next; + continue; } if (end > req_end) { @@ -1205,8 +1205,6 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, break; } } -next: - prev = va; } return op_map_cb(ops, priv,